From 8fbbd5127c1e355ecb933b5ffa9b1712b5ca5635 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Tue, 20 Aug 2019 15:18:18 -0700 Subject: [PATCH] =?UTF-8?q?Add=20aria=20labels=20to=20'=E2=80=A2=E2=80=A2?= =?UTF-8?q?=E2=80=A2'=20buttons=20in=20dacfx=20and=20schema=20compare=20(#?= =?UTF-8?q?6814)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * adding aria label to '•••' buttons in dacfx and schema compare extensions * add tooltips and more descriptive labels * fix typo --- extensions/dacpac/src/wizard/api/dacFxConfigPage.ts | 2 ++ extensions/schema-compare/src/dialogs/schemaCompareDialog.ts | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/extensions/dacpac/src/wizard/api/dacFxConfigPage.ts b/extensions/dacpac/src/wizard/api/dacFxConfigPage.ts index beeb5c80f3..b084d114af 100644 --- a/extensions/dacpac/src/wizard/api/dacFxConfigPage.ts +++ b/extensions/dacpac/src/wizard/api/dacFxConfigPage.ts @@ -162,6 +162,8 @@ export abstract class DacFxConfigPage extends BasePage { this.fileTextBox.ariaLabel = localize('dacfx.fileLocationAriaLabel', "File Location"); this.fileButton = this.view.modelBuilder.button().withProperties({ label: '•••', + title: localize('dacfx.selectFile', "Select file"), + ariaLabel: localize('dacfx.selectFile', "Select file") }).component(); } diff --git a/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts b/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts index f438229f36..70f6703bce 100644 --- a/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts +++ b/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts @@ -289,10 +289,14 @@ export class SchemaCompareDialog { if (isTarget) { this.targetFileButton = view.modelBuilder.button().withProperties({ label: '•••', + title: localize('schemaCompare.selectTargetFile', "Select target file"), + ariaLabel: localize('schemaCompare.selectTargetFile', "Select target file") }).component(); } else { this.sourceFileButton = view.modelBuilder.button().withProperties({ label: '•••', + title: localize('schemaCompare.selectSourceFile', "Select source file"), + ariaLabel: localize('schemaCompare.selectSourceFile', "Select source file") }).component(); }