ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-14 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixing issue where sqlcmdvars wouldn't load from publish profile in ADS (#23116)

Browse Source 
* fixing issue where sqlcmdvars wouldn't load from publish profile in ADS

* in -> of
This commit is contained in:
Benjin Dubishar
2023-05-11 22:03:41 -07:00
committed by GitHub
parent 017bbe61d5
commit 9116f66ca4
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
View File

@@ -20,6 +20,7 @@ import { TelemetryActions, TelemetryReporter, TelemetryViews } from '../common/t
import { Deferred } from '../common/promise';
import { PublishOptionsDialog } from './publishOptionsDialog';
import { IPublishToDockerSettings, ISqlProjectPublishSettings } from '../models/deploy/publishSettings';
import { PublishProfile } from '../models/publishProfile/publishProfile';
interface DataSourceDropdownValue extends azdataType.CategoryValue {
dataSource: SqlConnectionDataSource;
@@ -69,7 +70,7 @@ export class PublishDatabaseDialog {
public publish: ((proj: Project, profile: ISqlProjectPublishSettings) => any) | undefined;
public publishToContainer: ((proj: Project, profile: IPublishToDockerSettings) => any) | undefined;
public generateScript: ((proj: Project, profile: ISqlProjectPublishSettings) => any) | undefined;
public readPublishProfile: ((profileUri: vscode.Uri) => any) | undefined;
public readPublishProfile: ((profileUri: vscode.Uri) => Promise<PublishProfile>) | undefined;
public savePublishProfile: ((profilePath: string, databaseName: string, connectionString: string, sqlCommandVariableValues?: Map<string, string>, deploymentOptions?: DeploymentOptions) => any) | undefined;
constructor(private project: Project) {
@@ -814,8 +815,8 @@ export class PublishDatabaseDialog {
this.formBuilder?.removeFormItem(<azdataType.FormComponentGroup>this.sqlCmdVariablesFormComponentGroup);
}
for (let key in result.sqlCmdVariables) {
this.sqlCmdVars?.set(key, result.sqlCmdVariableColumn.get(key));
for (let key of result.sqlCmdVariables.keys()) {
this.sqlCmdVars?.set(key, result.sqlCmdVariables.get(key)!);
}
this.updateRevertSqlCmdVarsButtonState();
@@ -983,7 +984,7 @@ export class PublishDatabaseDialog {
/*
* Sets the default deployment options to deployment options model object
*/
public setDeploymentOptions(deploymentOptions: DeploymentOptions): void {
public setDeploymentOptions(deploymentOptions: DeploymentOptions | undefined): void {
this.deploymentOptions = deploymentOptions;
}
}