ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Let's log every potential failure (#10342)

Browse Source 
* Let's log every potential failure

* Add more context to the error
This commit is contained in:
Amir Omidi
2020-05-11 13:02:28 -07:00
committed by GitHub
parent 567c1be9fb
commit 923272f989
2 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/azurecore/src/account-provider/auths/azureAuth.ts
View File

@@ -225,7 +225,6 @@ export abstract class AzureAuth implements vscode.Disposable {
} catch (ex) { } catch (ex) {
console.log(`Could not refresh access token for ${JSON.stringify(tenant)} - silently removing the tenant from the user's account.`); console.log(`Could not refresh access token for ${JSON.stringify(tenant)} - silently removing the tenant from the user's account.`);
azureAccount.properties.tenants = azureAccount.properties.tenants.filter(t => t.id !== tenant.id); azureAccount.properties.tenants = azureAccount.properties.tenants.filter(t => t.id !== tenant.id);
console.log(ex, ex?.data, ex?.response);
continue; continue;
} }
@@ -272,6 +271,7 @@ export abstract class AzureAuth implements vscode.Disposable {
} }
protected async makePostRequest(uri: string, postData: { [key: string]: string }, validateStatus = false) { protected async makePostRequest(uri: string, postData: { [key: string]: string }, validateStatus = false) {
try {
const config: AxiosRequestConfig = { const config: AxiosRequestConfig = {
headers: { headers: {
'Content-Type': 'application/x-www-form-urlencoded' 'Content-Type': 'application/x-www-form-urlencoded'
@@ -282,10 +282,15 @@ export abstract class AzureAuth implements vscode.Disposable {
config.validateStatus = () => true; config.validateStatus = () => true;
} }
return axios.post(uri, qs.stringify(postData), config); return await axios.post(uri, qs.stringify(postData), config);
} catch (ex) {
console.log('Unexpected error making Azure auth request', 'azureCore.postRequest', JSON.stringify(ex?.response?.data, undefined, 2));
throw ex;
}
} }
protected async makeGetRequest(token: string, uri: string): Promise<AxiosResponse<any>> { protected async makeGetRequest(token: string, uri: string): Promise<AxiosResponse<any>> {
try {
const config = { const config = {
headers: { headers: {
Authorization: `Bearer ${token}`, Authorization: `Bearer ${token}`,
@@ -293,7 +298,13 @@ export abstract class AzureAuth implements vscode.Disposable {
}, },
}; };
return axios.get(uri, config); return await axios.get(uri, config);
} catch (ex) {
// Intercept and print error
console.log('Unexpected error making Azure auth request', 'azureCore.getRequest', JSON.stringify(ex?.response?.data, undefined, 2));
// rethrow error
throw ex;
}
} }
protected async getTenants(token: AccessToken): Promise<Tenant[]> { protected async getTenants(token: AccessToken): Promise<Tenant[]> {
@@ -325,7 +336,6 @@ export abstract class AzureAuth implements vscode.Disposable {
return tenants; return tenants;
} catch (ex) { } catch (ex) {
console.log(ex); console.log(ex);
console.log(JSON.stringify(ex?.response?.data, undefined, 2));
throw new Error('Error retreiving tenant information'); throw new Error('Error retreiving tenant information');
} }
} }

1
extensions/azurecore/src/account-provider/auths/azureDeviceCode.ts
View File

@@ -150,6 +150,7 @@ export class AzureDeviceCode extends AzureAuth {
return result; return result;
} catch (ex) { } catch (ex) {
console.log(ex); console.log(ex);
console.log('Unexpected error making Azure auth request', 'azureCore.checkForResult', JSON.stringify(ex?.response?.data, undefined, 2));
throw new Error(msg); throw new Error(msg);
} }
} }