ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Detect when resultset length changes and force buffer recreation (#5522)

Browse Source
This commit is contained in:
Karl Burtram
2019-05-20 08:14:12 -07:00
committed by GitHub
parent 5d44b6a6a7
commit 9268513128
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/base/browser/ui/table/asyncDataView.ts
View File

@@ -78,6 +78,7 @@ export class VirtualizedCollection<T extends Slick.SlickData> implements IObserv
private _bufferWindowBefore: DataWindow<T>; private _bufferWindowBefore: DataWindow<T>;
private _window: DataWindow<T>; private _window: DataWindow<T>;
private _bufferWindowAfter: DataWindow<T>; private _bufferWindowAfter: DataWindow<T>;
private _lengthChanged = false;
private collectionChangedCallback: (startIndex: number, count: number) => void; private collectionChangedCallback: (startIndex: number, count: number) => void;
@@ -113,7 +114,10 @@ export class VirtualizedCollection<T extends Slick.SlickData> implements IObserv
} }
setLength(length: number): void { setLength(length: number): void {
this.length = length; if (this.length !== length) {
this._lengthChanged = true;
this.length = length;
}
} }
public at(index: number): T { public at(index: number): T {
@@ -126,8 +130,9 @@ export class VirtualizedCollection<T extends Slick.SlickData> implements IObserv
let currentData = this.getRangeFromCurrent(start, end); let currentData = this.getRangeFromCurrent(start, end);
// only shift window and make promise of refreshed data in following condition: // only shift window and make promise of refreshed data in following condition:
if (start < this._bufferWindowBefore.getStartIndex() || end > this._bufferWindowAfter.getEndIndex()) { if (this._lengthChanged || start < this._bufferWindowBefore.getStartIndex() || end > this._bufferWindowAfter.getEndIndex()) {
// jump, reset // jump, reset
this._lengthChanged = false;
this.resetWindowsAroundIndex(start); this.resetWindowsAroundIndex(start);
} else if (end <= this._bufferWindowBefore.getEndIndex()) { } else if (end <= this._bufferWindowBefore.getEndIndex()) {
// scroll up, shift up // scroll up, shift up