ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-28 01:25:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix cell attachment types (#14485)

Browse Source
This commit is contained in:
Chris LaFreniere
2021-03-01 15:06:12 -08:00
committed by GitHub
parent ff508b1bf4
commit 9273572d5a
5 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/contrib/notebook/browser/cellViews/interfaces.ts
View File

@@ -34,9 +34,9 @@ export abstract class CellView extends AngularDisposable implements OnDestroy, I
}
export interface IMarkdownStringWithCellAttachments extends IMarkdownString {
readonly cellAttachments?: nb.ICellAttachment
readonly cellAttachments?: nb.ICellAttachments
}
export interface MarkdownRenderOptionsWithCellAttachments extends MarkdownRenderOptions {
readonly cellAttachments?: nb.ICellAttachment
readonly cellAttachments?: nb.ICellAttachments
}

2
src/sql/workbench/contrib/notebook/browser/outputs/notebookMarkdown.ts
View File

@@ -264,7 +264,7 @@ export class NotebookMarkdownRenderer {
* In a cell, the above attachment would be referenced in markdown like this:
* ![altText](attachment:test.png)
*/
function findAttachmentIfExists(href: string, cellAttachments: nb.ICellAttachment): string {
function findAttachmentIfExists(href: string, cellAttachments: nb.ICellAttachments): string {
if (href.startsWith('attachment:') && cellAttachments) {
const imageName = href.replace('attachment:', '');
const imageDefinition = cellAttachments[imageName];