ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix cell attachment types (#14485)

Browse Source
This commit is contained in:
Chris LaFreniere
2021-03-01 15:06:12 -08:00
committed by GitHub
parent ff508b1bf4
commit 9273572d5a
5 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/azdata.proposed.d.ts vendored
View File

@@ -83,10 +83,12 @@ declare module 'azdata' {
} }
export interface ICellContents { export interface ICellContents {
attachments?: ICellAttachment; attachments?: ICellAttachments;
} }
export type ICellAttachment = { [key: string]: { [key: string]: string } }; export type ICellAttachments = { [key: string]: ICellAttachment };
export type ICellAttachment = { [key: string]: string };
} }
export type SqlDbType = 'BigInt' | 'Binary' | 'Bit' | 'Char' | 'DateTime' | 'Decimal' export type SqlDbType = 'BigInt' | 'Binary' | 'Bit' | 'Char' | 'DateTime' | 'Decimal'

4
src/sql/workbench/contrib/notebook/browser/cellViews/interfaces.ts
View File

@@ -34,9 +34,9 @@ export abstract class CellView extends AngularDisposable implements OnDestroy, I
} }
export interface IMarkdownStringWithCellAttachments extends IMarkdownString { export interface IMarkdownStringWithCellAttachments extends IMarkdownString {
readonly cellAttachments?: nb.ICellAttachment readonly cellAttachments?: nb.ICellAttachments
} }
export interface MarkdownRenderOptionsWithCellAttachments extends MarkdownRenderOptions { export interface MarkdownRenderOptionsWithCellAttachments extends MarkdownRenderOptions {
readonly cellAttachments?: nb.ICellAttachment readonly cellAttachments?: nb.ICellAttachments
} }

2
src/sql/workbench/contrib/notebook/browser/outputs/notebookMarkdown.ts
View File

@@ -264,7 +264,7 @@ export class NotebookMarkdownRenderer {
* In a cell, the above attachment would be referenced in markdown like this: * In a cell, the above attachment would be referenced in markdown like this:
* ![altText](attachment:test.png) * ![altText](attachment:test.png)
*/ */
function findAttachmentIfExists(href: string, cellAttachments: nb.ICellAttachment): string { function findAttachmentIfExists(href: string, cellAttachments: nb.ICellAttachments): string {
if (href.startsWith('attachment:') && cellAttachments) { if (href.startsWith('attachment:') && cellAttachments) {
const imageName = href.replace('attachment:', ''); const imageName = href.replace('attachment:', '');
const imageDefinition = cellAttachments[imageName]; const imageDefinition = cellAttachments[imageName];

2
src/sql/workbench/services/notebook/browser/models/cell.ts
View File

@@ -80,7 +80,7 @@ export class CellModel extends Disposable implements ICellModel {
private _isParameter: boolean; private _isParameter: boolean;
private _onParameterStateChanged = new Emitter<boolean>(); private _onParameterStateChanged = new Emitter<boolean>();
private _isInjectedParameter: boolean; private _isInjectedParameter: boolean;
private _attachments: nb.ICellAttachment; private _attachments: nb.ICellAttachments;
constructor(cellData: nb.ICellContents, constructor(cellData: nb.ICellContents,
private _options: ICellModelOptions, private _options: ICellModelOptions,

2
src/sql/workbench/services/notebook/browser/models/modelInterfaces.ts
View File

@@ -530,7 +530,7 @@ export interface ICellModel {
sendChangeToNotebook(change: NotebookChangeType): void; sendChangeToNotebook(change: NotebookChangeType): void;
cellSourceChanged: boolean; cellSourceChanged: boolean;
readonly savedConnectionName: string | undefined; readonly savedConnectionName: string | undefined;
readonly attachments: nb.ICellAttachment; readonly attachments: nb.ICellAttachments;
readonly currentMode: CellEditModes; readonly currentMode: CellEditModes;
} }