ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adds ariaRowcount to virtualized tables in SchemaCompare options (#6816)

Browse Source 
* Adds button extension for explicitly setting aria-label, in case the label is not screen-reader friendly

* Explicitly set aria-label for ellipsis buttons in SchemaCompare

* Changing localize call to double-quotes

* Removes unused getter for ariaLabel

* Adding aria-rowcounts for long scrollable tables
This commit is contained in:
Benjin Dubishar
2019-08-20 13:17:13 -07:00
committed by GitHub
parent 4fb53622bc
commit 949ea4b6c3
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
extensions/schema-compare/src/dialogs/schemaCompareOptionsDialog.ts
View File

@@ -14,6 +14,9 @@ import { isNullOrUndefined } from 'util';
const localize = nls.loadMessageBundle(); const localize = nls.loadMessageBundle();
export class SchemaCompareOptionsDialog { export class SchemaCompareOptionsDialog {
//#region Localized strings
private static readonly OkButtonText: string = localize('SchemaCompareOptionsDialog.Ok', 'OK'); private static readonly OkButtonText: string = localize('SchemaCompareOptionsDialog.Ok', 'OK');
private static readonly CancelButtonText: string = localize('SchemaCompareOptionsDialog.Cancel', 'Cancel'); private static readonly CancelButtonText: string = localize('SchemaCompareOptionsDialog.Cancel', 'Cancel');
private static readonly ResetButtonText: string = localize('SchemaCompareOptionsDialog.Reset', 'Reset'); private static readonly ResetButtonText: string = localize('SchemaCompareOptionsDialog.Reset', 'Reset');
@@ -246,6 +249,8 @@ export class SchemaCompareOptionsDialog {
private static readonly descriptionDropObjectsNotInSource: string = localize('SchemaCompare.Description.DropObjectsNotInSource', 'Specifies whether objects that do not exist in the database snapshot (.dacpac) file will be dropped from the target database when you publish to a database. This value takes precedence over DropExtendedProperties.'); private static readonly descriptionDropObjectsNotInSource: string = localize('SchemaCompare.Description.DropObjectsNotInSource', 'Specifies whether objects that do not exist in the database snapshot (.dacpac) file will be dropped from the target database when you publish to a database. This value takes precedence over DropExtendedProperties.');
private static readonly descriptionIgnoreColumnOrder: string = localize('SchemaCompare.Description.IgnoreColumnOrder', 'Specifies whether differences in table column order should be ignored or updated when you publish to a database.'); private static readonly descriptionIgnoreColumnOrder: string = localize('SchemaCompare.Description.IgnoreColumnOrder', 'Specifies whether differences in table column order should be ignored or updated when you publish to a database.');
//#endregion
public dialog: azdata.window.Dialog; public dialog: azdata.window.Dialog;
public deploymentOptions: mssql.DeploymentOptions; public deploymentOptions: mssql.DeploymentOptions;
@@ -581,7 +586,8 @@ export class SchemaCompareOptionsDialog {
cssClass: 'no-borders align-with-header', cssClass: 'no-borders align-with-header',
width: 50 width: 50
} }
] ],
ariaRowCount: data.length
}); });
} }
@@ -604,7 +610,8 @@ export class SchemaCompareOptionsDialog {
cssClass: 'no-borders align-with-header', cssClass: 'no-borders align-with-header',
width: 50 width: 50
} }
] ],
ariaRowCount: data.length
}); });
} }