ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration][Hotfix] Remove parameter from IR validation (#21800)

Browse Source 
* Remove encryptConnection from validateIR

* Use correct version

* vbump to 1.2.6 for insiders release
This commit is contained in:
Raymond Truong
2023-02-01 11:33:07 -08:00
committed by GitHub
parent 749f13d9bf
commit 95ce199d56
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/sql-migration/package.json
View File

@@ -2,7 +2,7 @@
"name": "sql-migration", "name": "sql-migration",
"displayName": "%displayName%", "displayName": "%displayName%",
"description": "%description%", "description": "%description%",
"version": "1.2.4", "version": "1.2.6",
"publisher": "Microsoft", "publisher": "Microsoft",
"preview": false, "preview": false,
"license": "https://raw.githubusercontent.com/Microsoft/azuredatastudio/main/LICENSE.txt", "license": "https://raw.githubusercontent.com/Microsoft/azuredatastudio/main/LICENSE.txt",

2
extensions/sql-migration/src/api/azure.ts
View File

@@ -736,8 +736,8 @@ export async function validateIrDatabaseMigrationSettings(
dataSource: sourceServerName, dataSource: sourceServerName,
userName: migration._sqlServerUsername, userName: migration._sqlServerUsername,
password: migration._sqlServerPassword, password: migration._sqlServerPassword,
// to-do: use correct value of encryptConnection and trustServerCertificate
trustServerCertificate: trustServerCertificate, trustServerCertificate: trustServerCertificate,
encryptConnection: true,
authentication: migration._authenticationType, authentication: migration._authenticationType,
} }
}; };

1
extensions/sql-migration/src/models/stateMachine.ts
View File

@@ -1141,6 +1141,7 @@ export class MigrationStateModel implements Model, vscode.Disposable {
authentication: this._authenticationType, authentication: this._authenticationType,
userName: this._sqlServerUsername, userName: this._sqlServerUsername,
password: this._sqlServerPassword, password: this._sqlServerPassword,
// to-do: use correct value of encryptConnection and trustServerCertificate
trustServerCertificate: currentConnection?.options.trustServerCertificate ?? false trustServerCertificate: currentConnection?.options.trustServerCertificate ?? false
}, },
scope: this._targetServerInstance.id, scope: this._targetServerInstance.id,