ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Stop executing the same code three times (#9835)

Browse Source 
* Stop executing the same code three times

* Remove one more extra call
This commit is contained in:
Amir Omidi
2020-04-15 13:56:12 -07:00
committed by GitHub
parent e6d882c9b5
commit 97108bdeea
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/services/connection/browser/connectionDialogService.ts
View File

@@ -423,7 +423,6 @@ export class ConnectionDialogService implements IConnectionDialogService {
this._params = params; this._params = params;
this._inputModel = model; this._inputModel = model;
return new Promise<void>((resolve, reject) => { return new Promise<void>((resolve, reject) => {
this.updateModelServerCapabilities(model);
// If connecting from a query editor set "save connection" to false // If connecting from a query editor set "save connection" to false
if (params && (params.input && params.connectionType === ConnectionType.editor || if (params && (params.input && params.connectionType === ConnectionType.editor ||
params.connectionType === ConnectionType.temporary)) { params.connectionType === ConnectionType.temporary)) {
@@ -455,7 +454,6 @@ export class ConnectionDialogService implements IConnectionDialogService {
this._connectionDialog.render(); this._connectionDialog.render();
} }
this._connectionDialog.newConnectionParams = params; this._connectionDialog.newConnectionParams = params;
this._connectionDialog.updateProvider(this._providerNameToDisplayNameMap[this._currentProviderType]);
const recentConnections: ConnectionProfile[] = this._connectionManagementService.getRecentConnections(params.providers); const recentConnections: ConnectionProfile[] = this._connectionManagementService.getRecentConnections(params.providers);
await this._connectionDialog.open(recentConnections.length > 0); await this._connectionDialog.open(recentConnections.length > 0);

1
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts
View File

@@ -277,7 +277,6 @@ export class ConnectionDialogWidget extends Modal {
// Show connection form based on server type // Show connection form based on server type
DOM.clearNode(this._connectionUIContainer); DOM.clearNode(this._connectionUIContainer);
this._onShowUiComponent.fire({ selectedProviderDisplayName: selectedProviderDisplayName, container: this._connectionUIContainer }); this._onShowUiComponent.fire({ selectedProviderDisplayName: selectedProviderDisplayName, container: this._connectionUIContainer });
this.initDialog();
} }
private connect(element?: IConnectionProfile): void { private connect(element?: IConnectionProfile): void {