Fix agent steps refresh when changing history (#9446)

* layering

* switch to events and emitters

* changed to self
This commit is contained in:
Aditya Bist
2020-03-05 12:33:47 -08:00
committed by GitHub
parent a93cc68e24
commit 997e91f19c
5 changed files with 33 additions and 18 deletions

View File

@@ -14,7 +14,7 @@ import { IWorkbenchThemeService } from 'vs/workbench/services/themes/common/work
import { CommonServiceInterface } from 'sql/workbench/services/bootstrap/browser/commonServiceInterface.service';
import {
JobStepsViewController, JobStepsViewDataSource, JobStepsViewFilter,
JobStepsViewRenderer, JobStepsViewModel
JobStepsViewRenderer, JobStepsViewModel, JobStepsViewRow
} from 'sql/workbench/contrib/jobManagement/browser/jobStepsViewTree';
import { JobHistoryComponent } from 'sql/workbench/contrib/jobManagement/browser/jobHistory.component';
import { JobManagementView } from 'sql/workbench/contrib/jobManagement/browser/jobManagementView';
@@ -25,6 +25,7 @@ import { IInstantiationService } from 'vs/platform/instantiation/common/instanti
import { TabChild } from 'sql/base/browser/ui/panel/tab.component';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys';
import { IJobManagementService } from 'sql/workbench/services/jobManagement/common/interfaces';
export const JOBSTEPSVIEW_SELECTOR: string = 'jobstepsview-component';
@@ -46,6 +47,7 @@ export class JobStepsViewComponent extends JobManagementView implements OnInit,
constructor(
@Inject(forwardRef(() => CommonServiceInterface)) commonService: CommonServiceInterface,
@Inject(forwardRef(() => JobHistoryComponent)) private _jobHistoryComponent: JobHistoryComponent,
@Inject(IJobManagementService) private _jobManagementService: IJobManagementService,
@Inject(IWorkbenchThemeService) private themeService: IWorkbenchThemeService,
@Inject(IInstantiationService) instantiationService: IInstantiationService,
@Inject(IContextMenuService) contextMenuService: IContextMenuService,
@@ -105,6 +107,10 @@ export class JobStepsViewComponent extends JobManagementView implements OnInit,
this._register(attachListStyler(this._tree, this.themeService));
const stepsTooltip = nls.localize('agent.steps', "Steps");
jQuery('.steps-header > .steps-icon').attr('title', stepsTooltip);
this._jobManagementService.stepsChanged((data: JobStepsViewRow[]) => {
this._treeDataSource.data = data;
this._tree.refresh();
});
this._telemetryService.publicLog(TelemetryKeys.JobStepsView);
}