From 9a1d823c69c411708b081fad0c4e531877c7e914 Mon Sep 17 00:00:00 2001
From: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Date: Wed, 27 Sep 2023 09:42:47 -0700
Subject: [PATCH] fixing a couple codeql warnings about incomplete string
 replacement (#24518)

---
 .../src/packageManagement/sqlRPackageManageProvider.ts          | 2 +-
 extensions/sql-bindings/src/common/utils.ts                     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/extensions/machine-learning/src/packageManagement/sqlRPackageManageProvider.ts b/extensions/machine-learning/src/packageManagement/sqlRPackageManageProvider.ts
index 52d166082e..723a87208e 100644
--- a/extensions/machine-learning/src/packageManagement/sqlRPackageManageProvider.ts
+++ b/extensions/machine-learning/src/packageManagement/sqlRPackageManageProvider.ts
@@ -71,7 +71,7 @@ export class SqlRPackageManageProvider extends SqlPackageManageProviderBase impl
 
 		if (connection) {
 			connectionParts.push(utils.getKeyValueString('driver', `"${constants.supportedODBCDriver}"`));
-			let server = connection.serverName.replace('\\', '\\\\');
+			let server = connection.serverName.replace(/\\/g, '\\\\');
 			if (databaseName) {
 				connectionParts.push(utils.getKeyValueString('database', `"${databaseName}"`));
 			}
diff --git a/extensions/sql-bindings/src/common/utils.ts b/extensions/sql-bindings/src/common/utils.ts
index 3fa6122bda..93ae49c399 100644
--- a/extensions/sql-bindings/src/common/utils.ts
+++ b/extensions/sql-bindings/src/common/utils.ts
@@ -114,7 +114,7 @@ export async function getUniqueFileName(fileName: string, folderPath?: string):
 }
 
 export function escapeClosingBrackets(str: string): string {
-	return str.replace(']', ']]');
+	return str.replace(/]/g, ']]');
 }
 
 /**