ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix null reference issue (#22113)

Browse Source 
* fix null reference issue

* move opendialog call out of promise.
This commit is contained in:
Alan Ren
2023-03-02 14:44:10 -08:00
committed by GitHub
parent da92875fea
commit 9b6018a21e
1 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/mssql/src/objectManagement/ui/objectManagementDialogBase.ts
View File

@@ -114,8 +114,10 @@ export abstract class ObjectManagementDialogBase<ObjectInfoType extends ObjectMa
public async open(): Promise<void> { public async open(): Promise<void> {
try { try {
const initializeViewPromise = new Promise<void>((async resolve => {
await this.dialogObject.registerContent(async view => { await this.dialogObject.registerContent(async view => {
this._modelView = view; this._modelView = view;
resolve();
this._formContainer = this.createFormContainer([]); this._formContainer = this.createFormContainer([]);
this._loadingComponent = view.modelBuilder.loadingComponent().withItem(this._formContainer).withProps({ this._loadingComponent = view.modelBuilder.loadingComponent().withItem(this._formContainer).withProps({
loading: true, loading: true,
@@ -126,10 +128,12 @@ export abstract class ObjectManagementDialogBase<ObjectInfoType extends ObjectMa
height: "100%" height: "100%"
} }
}).component(); }).component();
return view.initializeModel(this._loadingComponent); await view.initializeModel(this._loadingComponent);
}); });
}));
azdata.window.openDialog(this.dialogObject); azdata.window.openDialog(this.dialogObject);
this._viewInfo = await this.initializeData(); this._viewInfo = await this.initializeData();
await initializeViewPromise;
await this.initializeUI(); await this.initializeUI();
this._originalObjectInfo = deepClone(this.objectInfo); this._originalObjectInfo = deepClone(this.objectInfo);
const typeDisplayName = getNodeTypeDisplayName(this.objectType); const typeDisplayName = getNodeTypeDisplayName(this.objectType);