ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add more unit tests for JupyterServerInstallation (#12675)

Browse Source
This commit is contained in:
Cory Rivera
2020-10-01 13:54:12 -07:00
committed by GitHub
parent 4965f3de1a
commit 9b7a1d7a26
3 changed files with 117 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/notebook/src/jupyter/jupyterServerInstallation.ts
View File

@@ -55,7 +55,6 @@ export interface IJupyterServerInstallation {
uninstallPipPackages(packages: PythonPkgDetails[]): Promise<void>;
pythonExecutable: string;
pythonInstallationPath: string;
installPythonPackage(backgroundOperation: azdata.BackgroundOperation, usingExistingPython: boolean, pythonInstallationPath: string, outputChannel: vscode.OutputChannel): Promise<void>;
}
export class JupyterServerInstallation implements IJupyterServerInstallation {
public extensionPath: string;
@@ -160,7 +159,7 @@ export class JupyterServerInstallation implements IJupyterServerInstallation {
vscode.window.showInformationMessage(msgInstallPkgFinish);
}
public installPythonPackage(backgroundOperation: azdata.BackgroundOperation, usingExistingPython: boolean, pythonInstallationPath: string, outputChannel: vscode.OutputChannel): Promise<void> {
private installPythonPackage(backgroundOperation: azdata.BackgroundOperation, usingExistingPython: boolean, pythonInstallationPath: string, outputChannel: vscode.OutputChannel): Promise<void> {
if (usingExistingPython) {
return Promise.resolve();
}