ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-26 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add default model view input types and validation (#1397)

Browse Source
This commit is contained in:
Matt Irvine
2018-05-14 16:20:19 -07:00
committed by GitHub
parent 89c48bbe75
commit 9bd45cf66a
14 changed files with 363 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

97
src/sqltest/workbench/api/extHostModelView.test.ts
View File

@@ -19,9 +19,6 @@ suite('ExtHostModelView Validation Tests', () => {
let mockProxy: Mock<MainThreadModelViewShape>;
let modelView: sqlops.ModelView;
let inputBox: sqlops.InputBoxComponent;
let dropDownBox: sqlops.DropDownComponent;
let formContainer: sqlops.FormContainer;
let flexContainer: sqlops.FlexContainer;
let validText = 'valid';
let widgetId = 'widget_id';
let handle = 1;
@@ -38,7 +35,6 @@ suite('ExtHostModelView Validation Tests', () => {
$setLayout: (handle: number, componentId: string, layout: any) => undefined,
$setProperties: (handle: number, componentId: string, properties: { [key: string]: any }) => undefined,
$registerEvent: (handle: number, componentId: string) => undefined,
$notifyValidation: (handle: number, componentId: string, valid: boolean) => undefined,
dispose: () => undefined
}, MockBehavior.Loose);
let mainContext = <IMainContext>{
@@ -47,7 +43,6 @@ suite('ExtHostModelView Validation Tests', () => {
mockProxy.setup(x => x.$initializeModel(It.isAny(), It.isAny())).returns(() => Promise.resolve());
mockProxy.setup(x => x.$registerEvent(It.isAny(), It.isAny())).returns(() => Promise.resolve());
mockProxy.setup(x => x.$setProperties(It.isAny(), It.isAny(), It.isAny())).returns(() => Promise.resolve());
mockProxy.setup(x => x.$notifyValidation(It.isAny(), It.isAny(), It.isAny())).returns(() => Promise.resolve());
// Register a model view of an input box and drop down box inside a form container inside a flex container
extHostModelView = new ExtHostModelView(mainContext);
@@ -56,11 +51,11 @@ suite('ExtHostModelView Validation Tests', () => {
inputBox = view.modelBuilder.inputBox()
.withValidation(component => component.value === validText)
.component();
dropDownBox = view.modelBuilder.dropDown().component();
formContainer = view.modelBuilder.formContainer()
let dropDownBox = view.modelBuilder.dropDown().component();
let formContainer = view.modelBuilder.formContainer()
.withItems([inputBox, dropDownBox])
.component();
flexContainer = view.modelBuilder.flexContainer()
let flexContainer = view.modelBuilder.flexContainer()
.withItems([formContainer])
.component();
await view.initializeModel(flexContainer);
@@ -70,47 +65,57 @@ suite('ExtHostModelView Validation Tests', () => {
extHostModelView.$registerWidget(handle, widgetId, undefined, undefined);
});
test('The validity of a component and its containers gets set when it is initialized', done => {
try {
assert.equal(modelView.valid, false, 'modelView was not marked as invalid');
assert.equal(inputBox.valid, false, 'inputBox was not marked as invalid');
assert.equal(formContainer.valid, false, 'formContainer was not marked as invalid');
assert.equal(flexContainer.valid, false, 'flexContainer was not marked as invalid');
assert.equal(dropDownBox.valid, true, 'dropDownBox was marked as invalid');
done();
} catch (err) {
done(err);
}
test('The custom validation output of a component gets set when it is initialized', done => {
extHostModelView.$runCustomValidations(handle, inputBox.id).then(valid => {
try {
assert.equal(valid, false, 'Empty input box did not validate as false');
done();
} catch (err) {
done(err);
}
}, err => done(err));
});
test('Containers reflect validity changes of contained components', done => {
try {
inputBox.value = validText;
assert.equal(modelView.valid, true, 'modelView was not marked as valid');
assert.equal(inputBox.valid, true, 'inputBox was not marked as valid');
assert.equal(formContainer.valid, true, 'formContainer was not marked as valid');
assert.equal(flexContainer.valid, true, 'flexContainer was not marked as valid');
done();
} catch (err) {
done(err);
}
test('The custom validation output of a component changes if its value changes', done => {
inputBox.value = validText;
extHostModelView.$runCustomValidations(handle, inputBox.id).then(valid => {
try {
assert.equal(valid, true, 'Valid input box did not validate as valid');
done();
} catch (err) {
done(err);
}
}, err => done(err));
});
test('PropertiesChanged events cause validation', done => {
try {
extHostModelView.$handleEvent(handle, inputBox.id, {
args: {
'value': validText
},
eventType: ComponentEventType.PropertiesChanged
} as IComponentEventArgs);
assert.equal(modelView.valid, true, 'modelView was not marked as valid');
assert.equal(inputBox.valid, true, 'inputBox was not marked as valid');
assert.equal(formContainer.valid, true, 'formContainer was not marked as valid');
assert.equal(flexContainer.valid, true, 'flexContainer was not marked as valid');
done();
} catch (err) {
done(err);
}
test('The custom validation output of a component changes after a PropertiesChanged event', done => {
extHostModelView.$handleEvent(handle, inputBox.id, {
args: {
'value': validText
},
eventType: ComponentEventType.PropertiesChanged
} as IComponentEventArgs);
extHostModelView.$runCustomValidations(handle, inputBox.id).then(valid => {
try {
assert.equal(valid, true, 'Valid input box did not validate as valid after PropertiesChanged event');
done();
} catch (err) {
done(err);
}
}, err => done(err));
});
test('The validity of a component is set by main thread validationChanged events', () => {
assert.equal(inputBox.valid, true, 'Component validity is true by default');
extHostModelView.$handleEvent(handle, inputBox.id, {
eventType: ComponentEventType.validityChanged,
args: false
});
assert.equal(inputBox.valid, false, 'Input box did not update validity to false based on the validityChanged event');
extHostModelView.$handleEvent(handle, inputBox.id, {
eventType: ComponentEventType.validityChanged,
args: true
});
assert.equal(inputBox.valid, true, 'Input box did not update validity to true based on the validityChanged event');
});
});