More layering (#6541)

* layer unlayered code; fix layering

* readd os

* fix definition of recommended extensions

* protect against tests

src/sql/platform/telemetry/common/telemetry.ts

@@ -0,0 +1,87 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
+
+export const IAdsTelemetryService = createDecorator<IAdsTelemetryService>('adsTelemetryService');
+
+/**
+ * Holds additional properties to send along with an event.
+ */
+export interface ITelemetryEventProperties {
+	[key: string]: string;
+}
+
+/**
+ * Holds additional measures to send along with an event.
+ */
+export interface ITelemetryEventMeasures {
+	[key: string]: number;
+}
+
+/**
+ * Connection info properties to add into an event.
+ */
+export interface ITelemetryConnectionInfo {
+	authenticationType?: string;
+	providerName?: string;
+	serverType?: string;
+	engineType?: string;
+}
+
+export interface ITelemetryEvent {
+	/**
+	 * Sends the event
+	 */
+	send(): void;
+
+	/**
+	 * Adds additional custom properties to this event.
+	 * @param additionalProperties The additional properties to add
+	 */
+	withAdditionalProperties(additionalProperties: ITelemetryEventProperties): ITelemetryEvent;
+
+	/**
+	 * Adds additional custom measurements to this event.
+	 * @param additionalMeasurements The additional measurements to add
+	 */
+	withAdditionalMeasurements(additionalMeasurements: ITelemetryEventMeasures): ITelemetryEvent;
+
+	/**
+	 * Adds additional connection-related information to this event.
+	 * @param connectionInfo The connection info to add. Only the fields in TelemetryConnectionInfo are included, all others are ignored.
+	 */
+	withConnectionInfo(connectionInfo: ITelemetryConnectionInfo): ITelemetryEvent;
+}
+
+export interface ITelemetryInfo {
+	sessionId: string;
+	machineId: string;
+	instanceId: string;
+}
+
+export interface IAdsTelemetryService {
+
+	// ITelemetryService functions
+	_serviceBrand: any;
+
+	setEnabled(value: boolean): void;
+
+	getTelemetryInfo(): Promise<ITelemetryInfo>;
+
+	isOptedIn: boolean;
+
+	// Custom event functions
+	createViewEvent(view: string): ITelemetryEvent;
+	sendViewEvent(view: string): void;
+	createActionEvent(view: string, action: string, target?: string, source?: string, durationInMs?: number): ITelemetryEvent;
+	sendActionEvent(view: string, action: string, target?: string, source?: string, durationInMs?: number): void;
+	createMetricsEvent(metrics: ITelemetryEventMeasures, groupName: string): ITelemetryEvent;
+	sendMetricsEvent(metrics: ITelemetryEventMeasures, groupName: string): void;
+	createErrorEvent(view: string, name: string, errorCode?: string, errorType?: string): ITelemetryEvent;
+	sendErrorEvent(view: string, name: string, errorCode?: string, errorType?: string): void;
+	createTelemetryEvent(eventName: string, properties?: ITelemetryEventProperties, measurements?: ITelemetryEventMeasures): ITelemetryEvent;
+	sendTelemetryEvent(eventName: string, properties?: ITelemetryEventProperties, measurements?: ITelemetryEventMeasures): void;
+}