More layering (#6541)

* layer unlayered code; fix layering

* readd os

* fix definition of recommended extensions

* protect against tests
This commit is contained in:
Anthony Dresser
2019-07-31 22:20:39 -07:00
committed by GitHub
parent 161c182a56
commit 9bfe8813b1
38 changed files with 77 additions and 67 deletions

View File

@@ -32,7 +32,7 @@ import { registerNotebookThemes } from 'sql/workbench/parts/notebook/browser/not
import { IQueryManagementService } from 'sql/platform/query/common/queryManagement';
import { notebookConstants } from 'sql/workbench/parts/notebook/common/models/modelInterfaces';
import { ILifecycleService } from 'vs/platform/lifecycle/common/lifecycle';
import { SqlNotebookProvider } from 'sql/workbench/services/notebook/sql/sqlNotebookProvider';
import { SqlNotebookProvider } from 'sql/workbench/services/notebook/common/sql/sqlNotebookProvider';
import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService';
import { keys } from 'vs/base/common/map';
import { IFileService, IFileStatWithMetadata } from 'vs/platform/files/common/files';

View File

@@ -9,7 +9,7 @@ import * as vscode from 'vscode';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { SQL_NOTEBOOK_PROVIDER } from 'sql/workbench/services/notebook/common/notebookService';
import { LocalContentManager } from 'sql/workbench/services/notebook/common/localContentManager';
import { SqlSessionManager } from 'sql/workbench/services/notebook/sql/sqlSessionManager';
import { SqlSessionManager } from 'sql/workbench/services/notebook/common/sql/sqlSessionManager';
export class SqlNotebookManager implements nb.NotebookProvider {
private _contentManager: nb.ContentManager;
@@ -47,4 +47,4 @@ export class SqlNotebookManager implements nb.NotebookProvider {
public get standardKernels(): nb.IStandardKernel[] {
return [];
}
}
}

View File

@@ -7,7 +7,7 @@ import { URI } from 'vs/base/common/uri';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { INotebookManager, INotebookProvider, SQL_NOTEBOOK_PROVIDER } from 'sql/workbench/services/notebook/common/notebookService';
import { SqlNotebookManager } from 'sql/workbench/services/notebook/sql/sqlNotebookManager';
import { SqlNotebookManager } from 'sql/workbench/services/notebook/common/sql/sqlNotebookManager';
export class SqlNotebookProvider implements INotebookProvider {
private manager: SqlNotebookManager;
@@ -27,4 +27,4 @@ export class SqlNotebookProvider implements INotebookProvider {
handleNotebookClosed(notebookUri: URI): void {
// No-op
}
}
}