ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 17:24:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

controller dropdown field to SQL MIAA and Postgres deployment. (#12217)

Browse Source 
* saving first draft

* throw if no controllers

* cleanup

* bug fixes

* bug fixes and caching controller access

* pr comments and bug fixes.

* fixes

* fixes

* comment fix

* remove debug prints

* comment fixes

* remove debug logs

* inputValueTransformer returns string|Promise

* PR feedback

* pr fixes

* remove _ from protected fields

* anonymous to full methods

* small fixes
This commit is contained in:
Arvind Ranasaria
2020-09-15 14:47:49 -07:00
committed by GitHub
parent 92ed830564
commit 9cf80113fc
36 changed files with 754 additions and 190 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/resource-deployment/src/ui/deploymentInputDialog.ts
View File

@@ -94,9 +94,9 @@ export class DeploymentInputDialog extends DialogBase {
});
}
protected onComplete(): void {
protected async onComplete(): Promise<void> {
const model: Model = new Model();
setModelValues(this.inputComponents, model);
await setModelValues(this.inputComponents, model);
if (instanceOfNotebookBasedDialogInfo(this.dialogInfo)) {
model.setEnvironmentVariables();
if (this.dialogInfo.runNotebook) {
@@ -110,7 +110,7 @@ export class DeploymentInputDialog extends DialogBase {
});
}
} else {
vscode.commands.executeCommand(this.dialogInfo.command, model);
await vscode.commands.executeCommand(this.dialogInfo.command, model);
}
}