Merge from vscode 1b314ab317fbff7d799b21754326b7d849889ceb

src/vs/workbench/workbench.web.api.ts

@@ -29,7 +29,7 @@ interface IStaticExtension {
 	isBuiltin?: boolean;
 }
 
-interface ICommontTelemetryPropertiesResolver {
+interface ICommonTelemetryPropertiesResolver {
 	(): { [key: string]: any };
 }
 
@@ -38,10 +38,12 @@ interface IExternalUriResolver {
 }
 
 interface ITunnelProvider {
+
 	/**
 	 * Support for creating tunnels.
 	 */
 	tunnelFactory?: ITunnelFactory;
+
 	/**
 	 * Support for filtering candidate ports
 	 */
@@ -106,11 +108,6 @@ interface IHomeIndicator {
 	 */
 	href: string;
 
-	/**
-	 * @deprecated use `href` instead.
-	 */
-	command?: string;
-
 	/**
 	 * The icon name for the home indicator. This needs to be one of the existing
 	 * icons from our Codicon icon set. For example `sync`.
@@ -174,14 +171,23 @@ interface IDefaultEditor {
 }
 
 interface IDefaultLayout {
-	/** @deprecated Use views instead */
+	/** @deprecated Use views instead (TODO@eamodio remove eventually) */
 	readonly sidebar?: IDefaultSideBarLayout;
-	/** @deprecated Use views instead */
+	/** @deprecated Use views instead (TODO@eamodio remove eventually) */
 	readonly panel?: IDefaultPanelLayout;
 	readonly views?: IDefaultView[];
 	readonly editors?: IDefaultEditor[];
 }
 
+interface IProductQualityChangeHandler {
+
+	/**
+	 * Handler is being called when the user wants to switch between
+	 * `insider` or `stable` product qualities.
+	 */
+	(newQuality: 'insider' | 'stable'): void;
+}
+
 interface IWorkbenchConstructionOptions {
 
 	//#region Connection related configuration
@@ -270,15 +276,10 @@ interface IWorkbenchConstructionOptions {
 	 */
 	readonly urlCallbackProvider?: IURLCallbackProvider;
 
-	/**
-	 * Support for update reporting.
-	 */
-	readonly updateProvider?: IUpdateProvider;
-
 	/**
 	 * Support adding additional properties to telemetry.
 	 */
-	readonly resolveCommonTelemetryProperties?: ICommontTelemetryPropertiesResolver;
+	readonly resolveCommonTelemetryProperties?: ICommonTelemetryPropertiesResolver;
 
 	/**
 	 * A set of optional commands that should be registered with the commands
@@ -296,6 +297,21 @@ interface IWorkbenchConstructionOptions {
 	//#endregion
 
 
+	//#region Update/Quality related
+
+	/**
+	 * Support for update reporting
+	 */
+	readonly updateProvider?: IUpdateProvider;
+
+	/**
+	 * Support for product quality switching
+	 */
+	readonly productQualityChangeHandler?: IProductQualityChangeHandler;
+
+	//#endregion
+
+
 	//#region Branding
 
 	/**
@@ -431,12 +447,13 @@ export {
 	// LogLevel
 	LogLevel,
 
-	// Updates
+	// Updates/Quality
 	IUpdateProvider,
 	IUpdate,
+	IProductQualityChangeHandler,
 
 	// Telemetry
-	ICommontTelemetryPropertiesResolver,
+	ICommonTelemetryPropertiesResolver,
 
 	// External Uris
 	IExternalUriResolver,