ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

add strict nulls for contrib/extensions (#11916)

Browse Source
This commit is contained in:
Anthony Dresser
2020-08-21 17:17:59 -07:00
committed by GitHub
parent f4f4271115
commit 9d680be37a
20 changed files with 125 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/services/insights/browser/insightsDialogController.ts
View File

@@ -20,7 +20,7 @@ import { ILogService } from 'vs/platform/log/common/log';
import { IFileService } from 'vs/platform/files/common/files';
import { URI } from 'vs/base/common/uri';
import { IInsightsDialogModel } from 'sql/workbench/services/insights/browser/insightsDialogService';
import { IInsightsConfigDetails } from 'sql/platform/dashboard/browser/insightRegistry';
import { IInsightsConfigDetails } from 'sql/platform/extensions/common/extensions';
export class InsightsDialogController {
private _queryRunner: QueryRunner;

2
src/sql/workbench/services/insights/browser/insightsDialogModel.ts
View File

@@ -6,7 +6,7 @@
import { IInsightsDialogModel, ListResource } from 'sql/workbench/services/insights/browser/insightsDialogService';
import { Event, Emitter } from 'vs/base/common/event';
import { IInsightsConfigDetails, IInsightsLabel } from 'sql/platform/dashboard/browser/insightRegistry';
import { IInsightsConfigDetails, IInsightsLabel } from 'sql/platform/extensions/common/extensions';
export enum Conditional {
'equals',

2
src/sql/workbench/services/insights/browser/insightsDialogService.ts
View File

@@ -7,7 +7,7 @@ import { createDecorator } from 'vs/platform/instantiation/common/instantiation'
import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
import { BaseActionContext } from 'sql/workbench/browser/actions';
import { IInsightsConfigDetails, IInsightsConfig } from 'sql/platform/dashboard/browser/insightRegistry';
import { IInsightsConfigDetails, IInsightsConfig } from 'sql/platform/extensions/common/extensions';
export interface IInsightsDialogModel {
rows: string[][];

2
src/sql/workbench/services/insights/browser/insightsDialogServiceImpl.ts
View File

@@ -8,8 +8,8 @@ import { InsightsDialogView } from 'sql/workbench/services/insights/browser/insi
import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
import { IInsightsDialogModel, IInsightsDialogService } from 'sql/workbench/services/insights/browser/insightsDialogService';
import { InsightsDialogModel } from 'sql/workbench/services/insights/browser/insightsDialogModel';
import { IInsightsConfig } from 'sql/platform/dashboard/browser/insightRegistry';
import { InsightsDialogController } from 'sql/workbench/services/insights/browser/insightsDialogController';
import { IInsightsConfig } from 'sql/platform/extensions/common/extensions';
export class InsightsDialogService implements IInsightsDialogService {
_serviceBrand: undefined;

2
src/sql/workbench/services/insights/browser/insightsDialogView.ts
View File

@@ -36,7 +36,6 @@ import { SplitView, Orientation, Sizing } from 'vs/base/browser/ui/splitview/spl
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { ILogService } from 'vs/platform/log/common/log';
import { IInsightsConfigDetails } from 'sql/platform/dashboard/browser/insightRegistry';
import { TaskRegistry } from 'sql/workbench/services/tasks/browser/tasksRegistry';
import { ITextResourcePropertiesService } from 'vs/editor/common/services/textResourceConfigurationService';
import { IAdsTelemetryService } from 'sql/platform/telemetry/common/telemetry';
@@ -49,6 +48,7 @@ import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { ILayoutService } from 'vs/platform/layout/browser/layoutService';
import { Registry } from 'vs/platform/registry/common/platform';
import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors';
import { IInsightsConfigDetails } from 'sql/platform/extensions/common/extensions';
const labelDisplay = nls.localize("insights.item", "Item");
const valueDisplay = nls.localize("insights.value", "Value");

2
src/sql/workbench/services/insights/test/browser/insightsDialogController.test.ts
View File

@@ -15,11 +15,11 @@ import { equal } from 'assert';
import { Mock, MockBehavior, It } from 'typemoq';
import { Emitter } from 'vs/base/common/event';
import { InsightsDialogModel } from 'sql/workbench/services/insights/browser/insightsDialogModel';
import { IInsightsConfigDetails } from 'sql/platform/dashboard/browser/insightRegistry';
import { TestCapabilitiesService } from 'sql/platform/capabilities/test/common/testCapabilitiesService';
import { IStorageService } from 'vs/platform/storage/common/storage';
import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock';
import { TestStorageService } from 'vs/workbench/test/common/workbenchTestServices';
import { IInsightsConfigDetails } from 'sql/platform/extensions/common/extensions';
const testData: string[][] = [
['1', '2', '3', '4'],

2
src/sql/workbench/services/insights/test/browser/insightsDialogModel.test.ts
View File

@@ -7,7 +7,7 @@ import { InsightsDialogModel } from 'sql/workbench/services/insights/browser/ins
import { isUndefinedOrNull } from 'vs/base/common/types';
import * as assert from 'assert';
import { IInsightsLabel, IInsightsConfigDetails } from 'sql/platform/dashboard/browser/insightRegistry';
import { IInsightsLabel, IInsightsConfigDetails } from 'sql/platform/extensions/common/extensions';
suite('Insights Dialog Model Tests', () => {
test('does parse condition right', () => {