From 9e3bfea9225b7a5ab651a3b60cbd463451fbd1fb Mon Sep 17 00:00:00 2001
From: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Date: Thu, 14 Jan 2021 15:45:22 -0800
Subject: [PATCH] fix flaky data workspace test (#13965)

---
 .../src/test/dialogs/openExistingDialog.test.ts           | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/extensions/data-workspace/src/test/dialogs/openExistingDialog.test.ts b/extensions/data-workspace/src/test/dialogs/openExistingDialog.test.ts
index 9076339a38..505aab60bf 100644
--- a/extensions/data-workspace/src/test/dialogs/openExistingDialog.test.ts
+++ b/extensions/data-workspace/src/test/dialogs/openExistingDialog.test.ts
@@ -8,7 +8,7 @@ import * as TypeMoq from 'typemoq';
 import * as sinon from 'sinon';
 import * as vscode from 'vscode';
 import * as constants from '../../common/constants';
-import { promises as fs } from 'fs';
+import * as utils from '../../common/utils';
 import { WorkspaceService } from '../../services/workspaceService';
 import { OpenExistingDialog } from '../../dialogs/openExistingDialog';
 import { createProjectFile, generateUniqueProjectFilePath, generateUniqueWorkspaceFilePath, testProjectType } from '../testUtils';
@@ -47,16 +47,16 @@ suite('Open Existing Dialog', function (): void {
 
 		dialog._targetTypeRadioCardGroup?.updateProperty( 'selectedCardId', constants.Workspace);
 		dialog._filePathTextBox!.value = 'nonExistentWorkspaceFile';
+		const fileExistStub = sinon.stub(utils, 'fileExist').resolves(false);
 
 		const validateResult = await dialog.validate();
-
 		const msg = constants.FileNotExistError('workspace', 'nonExistentWorkspaceFile');
 		should.equal(dialog.dialogObject.message.text, msg);
 		should.equal(validateResult, false, 'Validation should fail because workspace file does not exist, but passed');
 
-		// create a workspace file
+		// validation should pass if workspace file exists
 		dialog._filePathTextBox!.value = generateUniqueWorkspaceFilePath();
-		await fs.writeFile(dialog._filePathTextBox!.value , '');
+		fileExistStub.resolves(true);
 		should.equal(await dialog.validate(), true, `Validation should pass because workspace file exists, but failed with: ${dialog.dialogObject.message.text}`);
 	});