ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 09:38:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Agent action icons fix (#1255)

Browse Source 
* change icon opacity based on job status

* rid of magic numbers
This commit is contained in:
Aditya Bist
2018-04-25 12:20:46 -07:00
committed by GitHub
parent 7b76d929cd
commit 9e9862c6f0
3 changed files with 59 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/sql/parts/jobManagement/common/agentJobUtilities.ts
View File

@@ -9,6 +9,9 @@ import * as nls from 'vs/nls';
export class AgentJobUtilities {
public static startIconClass: string = 'icon-start';
public static stopIconClass: string = 'icon-stop';
public static convertToStatusString(status: number): string {
switch(status) {
case(0): return nls.localize('agentUtilities.failed','Failed');
@@ -51,4 +54,41 @@ export class AgentJobUtilities {
return date;
}
}
public static setRunnable(icon: HTMLElement, index: number) {
if (icon.className.includes('non-runnable')) {
icon.className = icon.className.slice(0, index);
}
}
public static getActionIconClassName(startIcon: HTMLElement, stopIcon: HTMLElement, executionStatus: number) {
this.setRunnable(startIcon, AgentJobUtilities.startIconClass.length);
this.setRunnable(stopIcon, AgentJobUtilities.stopIconClass.length);
switch (executionStatus) {
case(1): // executing
startIcon.className += ' non-runnable';
return;
case(2): // Waiting for thread
startIcon.className += ' non-runnable';
return;
case(3): // Between retries
startIcon.className += ' non-runnable';
return;
case(4): //Idle
stopIcon.className += ' non-runnable';
return;
case(5): // Suspended
stopIcon.className += ' non-runnable';
return;
case(6): //obsolete
startIcon.className += ' non-runnable';
stopIcon.className += ' non-runnable';
return;
case(7): //Performing Completion Actions
startIcon.className += ' non-runnable';
return;
default:
return;
}
}
}

7
src/sql/parts/jobManagement/views/jobHistory.component.ts
View File

@@ -131,6 +131,7 @@ export class JobHistoryComponent extends Disposable implements OnInit {
this._agentJobInfo = this._agentViewComponent.agentJobInfo;
if (!this.agentJobInfo) {
this.agentJobInfo = this._agentJobInfo;
this.setActions();
}
if (this._isVisible === false && this._tableContainer.nativeElement.offsetParent !== null) {
this._isVisible = true;
@@ -273,6 +274,12 @@ export class JobHistoryComponent extends Disposable implements OnInit {
return time.replace('T', ' ');
}
private setActions(): void {
let startIcon: HTMLElement = $('.icon-start').get(0);
let stopIcon: HTMLElement = $('.icon-stop').get(0);
AgentJobUtilities.getActionIconClassName(startIcon, stopIcon, this.agentJobInfo.currentExecutionStatus);
}
public get showSteps(): boolean {
return this._showSteps;
}

13
src/sql/parts/jobManagement/views/jobHistory.css
View File

@@ -29,7 +29,6 @@ ul.action-buttons li {
padding-right: 25px;
display: inline-block;
width: 50px;
cursor: pointer;
}
.overview-container .overview-tab .resultsViewCollapsible {
@@ -134,6 +133,7 @@ input#accordion:checked ~ .accordion-content {
width: 20px;
background-image: url('../common/media/start.svg');
background-repeat: no-repeat;
cursor: pointer;
}
.vs ul.action-buttons .icon-stop,
@@ -144,6 +144,17 @@ input#accordion:checked ~ .accordion-content {
background-repeat: no-repeat;
height: 20px;
width: 20px;
cursor: pointer;
}
ul.action-buttons div.icon-start.non-runnable {
opacity: 0.4;
cursor: default;
}
ul.action-buttons div.icon-stop.non-runnable {
opacity: 0.4;
cursor: default;
}
.accordion-content #col1,