ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

ImageInsight Image Error Notification (#8086)

Browse Source 
* image visualization printout (needs localization)

* Add error image and log error

* "added alert error for invalid image"

* removed unnecessary spaces

* removed spaces on 61 and 66

* Added image and used notification service

* Removed unused import

* Changed wording for error
This commit is contained in:
Alex Ma
2019-10-30 14:48:12 -07:00
committed by GitHub
parent 79b6a14d64
commit 9eb319f392
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/workbench/parts/charts/browser/imageInsight.ts
View File

@@ -4,10 +4,11 @@
*--------------------------------------------------------------------------------------------*/ *--------------------------------------------------------------------------------------------*/
import { IInsight, IInsightData } from './interfaces'; import { IInsight, IInsightData } from './interfaces';
import { INotificationService } from 'vs/platform/notification/common/notification';
import { $ } from 'vs/base/browser/dom'; import { $ } from 'vs/base/browser/dom';
import { mixin } from 'vs/base/common/objects'; import { mixin } from 'vs/base/common/objects';
import { IInsightOptions, InsightType } from 'sql/workbench/parts/charts/common/interfaces'; import { IInsightOptions, InsightType } from 'sql/workbench/parts/charts/common/interfaces';
import * as nls from 'vs/nls';
export interface IConfig extends IInsightOptions { export interface IConfig extends IInsightOptions {
encoding?: string; encoding?: string;
@@ -29,7 +30,7 @@ export class ImageInsight implements IInsight {
private imageEle: HTMLImageElement; private imageEle: HTMLImageElement;
constructor(container: HTMLElement, options: IConfig) { constructor(container: HTMLElement, options: IConfig, @INotificationService private _notificationService: INotificationService) {
this._options = mixin(options, defaultConfig, false); this._options = mixin(options, defaultConfig, false);
this.imageEle = $('img'); this.imageEle = $('img');
container.appendChild(this.imageEle); container.appendChild(this.imageEle);
@@ -52,11 +53,16 @@ export class ImageInsight implements IInsight {
} }
set data(data: IInsightData) { set data(data: IInsightData) {
const that = this;
if (data.rows && data.rows.length > 0 && data.rows[0].length > 0) { if (data.rows && data.rows.length > 0 && data.rows[0].length > 0) {
let img = data.rows[0][0]; let img = data.rows[0][0];
if (this._options.encoding === 'hex') { if (this._options.encoding === 'hex') {
img = ImageInsight._hexToBase64(img); img = ImageInsight._hexToBase64(img);
} }
this.imageEle.onerror = function () {
this.src = require.toUrl(`./media/images/invalidImage.png`);
that._notificationService.error(nls.localize('invalidImage', "Table does not contain a valid image"));
};
this.imageEle.src = `data:image/${this._options.imageFormat};base64,${img}`; this.imageEle.src = `data:image/${this._options.imageFormat};base64,${img}`;
} }
} }

BIN
src/sql/workbench/parts/charts/browser/media/images/invalidImage.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 3.3 KiB