ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-10 18:22:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Genericify components (#12158)

Browse Source 
* Genericify components

* Fix compile issue

* Fix feedback

* Genericify azdata components (#12164)

* azdata generics

* Add the withProps method to azdata proposed as there may be mistakes with the interfaces in the generics

* Fix build issues because of other extensions

* Remove extra spaces
This commit is contained in:
Amir Omidi
2020-09-08 16:15:24 -07:00
committed by GitHub
parent e2b5e9bd66
commit 9ed274fb39
37 changed files with 490 additions and 423 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/sql/azdata.proposed.d.ts vendored
View File

@@ -231,10 +231,14 @@ declare module 'azdata' {
}
export interface ModelBuilder {
radioCardGroup(): ComponentBuilder<RadioCardGroupComponent>;
radioCardGroup(): ComponentBuilder<RadioCardGroupComponent, RadioCardGroupComponentProperties>;
tabbedPanel(): TabbedPanelComponentBuilder;
separator(): ComponentBuilder<SeparatorComponent>;
propertiesContainer(): ComponentBuilder<PropertiesContainerComponent>;
separator(): ComponentBuilder<SeparatorComponent, SeparatorComponentProperties>;
propertiesContainer(): ComponentBuilder<PropertiesContainerComponent, PropertiesContainerComponentProperties>;
}
export interface ComponentBuilder<TComponent extends Component, TPropertyBag extends ComponentProperties> {
withProps(properties: TPropertyBag): ComponentBuilder<TComponent, TPropertyBag>;
}
export interface RadioCard {
@@ -278,6 +282,9 @@ declare module 'azdata' {
}
export interface SeparatorComponent extends Component {
}
export interface SeparatorComponentProperties extends ComponentProperties {
}
export interface DeclarativeTableProperties extends ComponentProperties {
@@ -287,7 +294,7 @@ declare module 'azdata' {
ariaHidden?: boolean;
}
export interface ComponentWithIconProperties {
export interface ComponentWithIconProperties extends ComponentProperties {
/**
* The path for the icon with optional dark-theme away alternative
*/
@@ -409,12 +416,12 @@ declare module 'azdata' {
/**
* Builder for TabbedPannelComponent
*/
export interface TabbedPanelComponentBuilder extends ContainerBuilder<TabbedPanelComponent, TabbedPanelLayout, any> {
export interface TabbedPanelComponentBuilder extends ContainerBuilder<TabbedPanelComponent, TabbedPanelLayout, any, ComponentProperties> {
/**
* Add the tabs to the component
* @param tabs tabs/tab groups to be added
*/
withTabs(tabs: (Tab | TabGroup)[]): ContainerBuilder<TabbedPanelComponent, TabbedPanelLayout, any>;
withTabs(tabs: (Tab | TabGroup)[]): ContainerBuilder<TabbedPanelComponent, TabbedPanelLayout, any, ComponentProperties>;
}
export interface InputBoxProperties extends ComponentProperties {
@@ -450,7 +457,7 @@ declare module 'azdata' {
/**
* Properties for configuring a PropertiesContainerComponent
*/
export interface PropertiesContainerComponentProperties {
export interface PropertiesContainerComponentProperties extends ComponentProperties {
/**
* The properties to display
*/
@@ -463,7 +470,6 @@ declare module 'azdata' {
*/
export const onDidChangeActiveNotebookEditor: vscode.Event<NotebookEditor>;
}
export namespace window {
export interface ModelViewDashboard {
registerTabs(handler: (view: ModelView) => Thenable<(DashboardTab | DashboardTabGroup)[]>): void;
@@ -629,4 +635,10 @@ declare module 'azdata' {
*/
delete?: boolean;
}
export interface DiffEditorComponent {
/**
* Title of editor
*/
title: string;
}
}