Fixed #4485 add max-width for attachTo and tooltip (#5493)

* Added tooltip of selectBox and set max width of attach to

* Undo our change, vscode fixed the issue
This commit is contained in:
Yurong He
2019-05-30 15:19:06 -07:00
committed by GitHub
parent 8e3fa660fd
commit a026b682c4
2 changed files with 4 additions and 4 deletions

View File

@@ -42,6 +42,7 @@
.notebookEditor .labelOnLeftContainer { .notebookEditor .labelOnLeftContainer {
min-width: 100px; min-width: 100px;
max-width: 250px;
margin-right: 20px; margin-right: 20px;
font-size: 13px; font-size: 13px;
text-align: center; text-align: center;

View File

@@ -409,14 +409,13 @@ export class AttachToDropdown extends SelectBox {
else { else {
if (connections.length === 1 && connections[0] === msgAddNewConnection) { if (connections.length === 1 && connections[0] === msgAddNewConnection) {
connections.unshift(msgSelectConnection); connections.unshift(msgSelectConnection);
this.selectWithOptionName(msgSelectConnection);
} }
else { else {
if (!connections.includes(msgAddNewConnection)) { if (!connections.includes(msgAddNewConnection)) {
connections.push(msgAddNewConnection); connections.push(msgAddNewConnection);
} }
} }
this.setOptions(connections); this.setOptions(connections, 0);
} }
} }
} }
@@ -426,11 +425,11 @@ export class AttachToDropdown extends SelectBox {
if (!connections.includes(msgSelectConnection)) { if (!connections.includes(msgSelectConnection)) {
connections.unshift(msgSelectConnection); connections.unshift(msgSelectConnection);
} }
this.selectWithOptionName(msgSelectConnection);
if (!connections.includes(msgAddNewConnection)) { if (!connections.includes(msgAddNewConnection)) {
connections.push(msgAddNewConnection); connections.push(msgAddNewConnection);
} }
this.setOptions(connections); this.setOptions(connections, 0);
} }
return connections; return connections;
} }