ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove/comment out connection title generation from all areas. (#23873)

Browse Source
This commit is contained in:
Alex Ma
2023-07-18 10:47:50 -07:00
committed by GitHub
parent 992b19fe93
commit a0a685bbcf
25 changed files with 30 additions and 1189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/platform/connection/common/connectionManagement.ts
View File

@@ -381,15 +381,6 @@ export interface IConnectionManagementService {
* @returns the new valid password that is entered, or undefined if cancelled or errored.
*/
openChangePasswordDialog(profile: IConnectionProfile): Promise<string | undefined>;
/**
* Gets the formatted title of the connection profile for display.
* @param profile The connection profile we want to get the full display info for.
* @param getOptionsOnly Provide if you only want to get the differing advanced options (for some titles).
* @param includeGroupName Provide if you want to include the groupName as well (in areas that do not display the groupName).
* @returns The title formatted with server info in front, with non default options at the end.
*/
getEditorConnectionProfileTitle(profile: IConnectionProfile, getOptionsOnly?: boolean, includeGroupName?: boolean): string;
}
export enum RunQueryOnConnectionMode {

6
src/sql/platform/connection/common/connectionStore.ts
View File

@@ -326,12 +326,6 @@ export class ConnectionStore {
return this.convertToConnectionGroup(groups, profilesInConfiguration);
}
public getAllConnectionsFromConfig(): ConnectionProfile[] {
let profilesInConfiguration: ConnectionProfile[] | undefined;
profilesInConfiguration = this.connectionConfig.getConnections(true);
return profilesInConfiguration;
}
private convertToConnectionGroup(groups: IConnectionProfileGroup[], connections?: ConnectionProfile[], parent?: ConnectionProfileGroup): ConnectionProfileGroup[] {
const result: ConnectionProfileGroup[] = [];
const children = groups.filter(g => g.parentId === (parent ? parent.id : undefined));

4
src/sql/platform/connection/common/providerConnectionInfo.ts
View File

@@ -134,7 +134,7 @@ export class ProviderConnectionInfo implements azdata.ConnectionInfo {
this.options[name] = value;
}
public getServerInfo() {
private getServerInfo() {
let title = '';
if (this.serverCapabilities) {
title = this.serverName;
@@ -169,7 +169,7 @@ export class ProviderConnectionInfo implements azdata.ConnectionInfo {
return label;
}
public hasLoaded(): boolean {
private hasLoaded(): boolean {
return Object.keys(this.capabilitiesService.providers).length > 0;
}

4
src/sql/platform/connection/test/common/testConnectionManagementService.ts
View File

@@ -355,10 +355,6 @@ export class TestConnectionManagementService implements IConnectionManagementSer
return undefined;
}
getEditorConnectionProfileTitle(profile: IConnectionProfile, getOptionsOnly?: boolean, includeGroupName?: boolean): string {
return undefined!;
}
openCustomErrorDialog(options: azdata.window.IErrorDialogOptions): Promise<string | undefined> {
return undefined;
}