Fix #6477 controller login + fix dashboard layout (#6478)

* Fix #6477 controller login + fix dashboard layout
- Service endpoints shoudl be on own column, cut off smaller screen
- Controller login not working due to 404 error
This is due to a breaking API change
We have requested fixes to help mitigate need for cluster name,
but for now have a default value for this

Finally, modified code so it's easier to update swagger API
and also added instructions on how to update in future

extensions/big-data-cluster/src/bigDataCluster/tree/controllerTreeDataProvider.ts

@@ -18,6 +18,7 @@ import { LoadingControllerNode } from './loadingControllerNode';
 const CredentialNamespace = 'clusterControllerCredentials';
 
 interface IControllerInfoSlim {
+	clusterName: string;
 	url: string;
 	username: string;
 	password?: string;
@@ -57,6 +58,7 @@ export class ControllerTreeDataProvider implements vscode.TreeDataProvider<TreeN
 	}
 
 	public addController(
+		clusterName: string,
 		url: string,
 		username: string,
 		password: string,
@@ -64,7 +66,7 @@ export class ControllerTreeDataProvider implements vscode.TreeDataProvider<TreeN
 		masterInstance?: IEndPoint
 	): void {
 		this.removeNonControllerNodes();
-		this.root.addControllerNode(url, username, password, rememberPassword, masterInstance);
+		this.root.addControllerNode(clusterName, url, username, password, rememberPassword, masterInstance);
 		this.notifyNodeChanged();
 	}
 
@@ -118,7 +120,7 @@ export class ControllerTreeDataProvider implements vscode.TreeDataProvider<TreeN
 					password = await this.getPassword(c.url, c.username);
 				}
 				this.root.addChild(new ControllerNode(
-					c.url, c.username, password, c.rememberPassword,
+					c.clusterName, c.url, c.username, password, c.rememberPassword,
 					undefined, this.root, this, undefined
 				));
 			}
@@ -136,6 +138,7 @@ export class ControllerTreeDataProvider implements vscode.TreeDataProvider<TreeN
 		let controllers = this.root.children.map(e => {
 			let controller = e as ControllerNode;
 			return <IControllerInfoSlim>{
+				clusterName: controller.clusterName,
 				url: controller.url,
 				username: controller.username,
 				password: controller.password,
@@ -145,6 +148,7 @@ export class ControllerTreeDataProvider implements vscode.TreeDataProvider<TreeN
 
 		let controllersWithoutPassword = controllers.map(e => {
 			return <IControllerInfoSlim>{
+				clusterName: e.clusterName,
 				url: e.url,
 				username: e.username,
 				rememberPassword: e.rememberPassword

extensions/big-data-cluster/src/bigDataCluster/tree/controllerTreeNode.ts

@@ -113,14 +113,20 @@ export class ControllerRootNode extends ControllerTreeNode {
 		return this.children as ControllerNode[];
 	}
 
-	public addControllerNode(url: string, username: string, password: string, rememberPassword: boolean, masterInstance?: IEndPoint): void {
+	public addControllerNode(clusterName: string,
+		url: string,
+		username: string,
+		password: string,
+		rememberPassword: boolean,
+		masterInstance?: IEndPoint
+	): void {
 		let controllerNode = this.getExistingControllerNode(url, username);
 		if (controllerNode) {
 			controllerNode.password = password;
 			controllerNode.rememberPassword = rememberPassword;
 			controllerNode.clearChildren();
 		} else {
-			controllerNode = new ControllerNode(url, username, password, rememberPassword, undefined, this, this.treeChangeHandler, undefined);
+			controllerNode = new ControllerNode(clusterName, url, username, password, rememberPassword, undefined, this, this.treeChangeHandler, undefined);
 			this.addChild(controllerNode);
 		}
 
@@ -158,6 +164,7 @@ export class ControllerRootNode extends ControllerTreeNode {
 export class ControllerNode extends ControllerTreeNode {
 
 	constructor(
+		private _clusterName: string,
 		private _url: string,
 		private _username: string,
 		private _password: string,
@@ -184,7 +191,7 @@ export class ControllerNode extends ControllerTreeNode {
 		}
 
 		try {
-			let response = await getEndPoints(this._url, this._username, this._password, true);
+			let response = await getEndPoints(this._clusterName, this._url, this._username, this._password, true);
 			if (response && response.endPoints) {
 				let master = response.endPoints.find(e => e.name && e.name === 'sql-server-master');
 				this.addSqlMasterNode(master.endpoint, master.description);
@@ -226,6 +233,14 @@ export class ControllerNode extends ControllerTreeNode {
 		return item;
 	}
 
+	public get clusterName() {
+		return this._clusterName;
+	}
+
+	public set clusterName(clusterName: string) {
+		this._clusterName = clusterName;
+	}
+
 	public get url() {
 		return this._url;
 	}