fix test-extension-unit.js on mac (#17612)

* fix test-extensions-unit.js not working on mac

* add comment
This commit is contained in:
Kim Santiago
2021-11-05 17:22:38 -07:00
committed by GitHub
parent 9b06f3551d
commit a31388f37a

View File

@@ -74,12 +74,18 @@ for (const ext of argv.extensions) {
const command = `${process.env.INTEGRATION_TEST_ELECTRON_PATH} ${LINUX_EXTRA_ARGS} --extensionDevelopmentPath=${path.join(__dirname, '..', 'extensions', ext)} --extensionTestsPath=${path.join(__dirname, '..', 'extensions', ext, 'out', 'test')} --user-data-dir=${VSCODEUSERDATADIR} --extensions-dir=${VSCODEEXTENSIONSDIR} --remote-debugging-port=9222 --disable-telemetry --disable-crash-reporter --disable-updates --no-cached-data --disable-keytar`; const command = `${process.env.INTEGRATION_TEST_ELECTRON_PATH} ${LINUX_EXTRA_ARGS} --extensionDevelopmentPath=${path.join(__dirname, '..', 'extensions', ext)} --extensionTestsPath=${path.join(__dirname, '..', 'extensions', ext, 'out', 'test')} --user-data-dir=${VSCODEUSERDATADIR} --extensions-dir=${VSCODEEXTENSIONSDIR} --remote-debugging-port=9222 --disable-telemetry --disable-crash-reporter --disable-updates --no-cached-data --disable-keytar`;
console.log(`Command used: ${command}`); console.log(`Command used: ${command}`);
const env = {
VSCODE_CLI: 1, if (os.platform() === 'darwin') {
ELECTRON_ENABLE_STACK_DUMPING: 1, // passing in env on mac causes the executing the command to fail, so only pass in env for windows and linux
ELECTRON_ENABLE_LOGGING: 1 console.log(execSync(command, { stdio: 'inherit'}));
}; } else {
console.log(execSync(command, { stdio: 'inherit', env: env})); const env = {
VSCODE_CLI: 1,
ELECTRON_ENABLE_STACK_DUMPING: 1,
ELECTRON_ENABLE_LOGGING: 1
};
console.log(execSync(command, { stdio: 'inherit', env: env}));
}
// clean up // clean up
if (!process.env.NO_CLEANUP) { if (!process.env.NO_CLEANUP) {