ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove API compatibility layer for VS Code notebook extensions (#21225)

Browse Source
This commit is contained in:
Cory Rivera
2022-11-15 10:38:41 -08:00
committed by GitHub
parent 1105e4d15c
commit a37d6230f9
41 changed files with 74 additions and 2197 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/notebook/src/jupyter/jupyterKernel.ts
View File

@@ -3,7 +3,6 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import * as vscode from 'vscode';
import { nb } from 'azdata';
import { Kernel, KernelMessage } from '@jupyterlab/services';
@@ -91,7 +90,7 @@ export class JupyterKernel implements nb.IKernel {
requestExecute(content: nb.IExecuteRequest, disposeOnDone?: boolean): nb.IFuture {
content.code = Array.isArray(content.code) ? content.code.join('') : content.code;
content.code = content.code.replace(/\r+\n/gm, '\n'); // Remove \r (if it exists) from newlines
let futureImpl = this.kernelImpl.requestExecute(content as KernelMessage.IExecuteRequest & { notebookUri: vscode.Uri, cellUri: vscode.Uri, language: string, cellIndex: number }, disposeOnDone);
let futureImpl = this.kernelImpl.requestExecute(content as KernelMessage.IExecuteRequest & { language: string }, disposeOnDone);
return new JupyterFuture(futureImpl);
}

3
extensions/notebook/src/test/model/kernel.test.ts
View File

@@ -98,9 +98,6 @@ describe('Jupyter Session', function (): void {
// When I request execute
let future = kernel.requestExecute({
code: code,
cellIndex: 0,
cellUri: undefined,
notebookUri: undefined,
language: ''
}, true);