ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-27 09:35:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removes Builder references from modal (#4869)

Browse Source 
* remove builder from modal

* add more DOM methods
This commit is contained in:
Anthony Dresser
2019-04-09 00:28:52 -07:00
committed by GitHub
parent 8bdcc3267a
commit a4bd31e96a
7 changed files with 168 additions and 250 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/platform/accounts/browser/accountDialog.ts
View File

@@ -273,9 +273,9 @@ export class AccountDialog extends Modal {
AddAccountAction,
newProvider.addedProvider.id
);
addAccountAction.addAccountCompleteEvent(() => { this.hideSpinner(); });
addAccountAction.addAccountErrorEvent(msg => { this._onAddAccountErrorEmitter.fire(msg); });
addAccountAction.addAccountStartEvent(() => { this.showSpinner(); });
addAccountAction.addAccountCompleteEvent(() => this.spinner = false);
addAccountAction.addAccountErrorEvent(msg => this._onAddAccountErrorEmitter.fire(msg));
addAccountAction.addAccountStartEvent(() => this.spinner = true);
let providerView = new AccountPanel(
{

4
src/sql/platform/accounts/browser/autoOAuthDialog.ts
View File

@@ -137,7 +137,7 @@ export class AutoOAuthDialog extends Modal {
private addAccount() {
if (this._copyAndOpenButton.enabled) {
this._copyAndOpenButton.enabled = false;
this.showSpinner();
this.spinner = true;
this._onHandleAddAccount.fire();
}
}
@@ -149,7 +149,7 @@ export class AutoOAuthDialog extends Modal {
public close() {
this._copyAndOpenButton.enabled = true;
this._onCloseEvent.fire();
this.hideSpinner();
this.spinner = false;
this.hide();
}

10
src/sql/platform/accounts/browser/firewallRuleDialog.ts
View File

@@ -124,12 +124,12 @@ export class FirewallRuleDialog extends Modal {
});
// Create account picker with event handling
this._accountPickerService.addAccountCompleteEvent(() => this.hideSpinner());
this._accountPickerService.addAccountCompleteEvent(() => this.spinner = false);
this._accountPickerService.addAccountErrorEvent((msg) => {
this.hideSpinner();
this.spinner = false;
this._onAddAccountErrorEmitter.fire(msg);
});
this._accountPickerService.addAccountStartEvent(() => this.showSpinner());
this._accountPickerService.addAccountStartEvent(() => this.spinner = true);
this._accountPickerService.onAccountSelectionChangeEvent((account) => this.onAccountSelectionChange(account));
let azureAccountSection;
@@ -297,7 +297,7 @@ export class FirewallRuleDialog extends Modal {
public createFirewallRule() {
if (this._createButton.enabled) {
this._createButton.enabled = false;
this.showSpinner();
this.spinner = true;
this._onCreateFirewallRule.fire();
}
}
@@ -313,7 +313,7 @@ export class FirewallRuleDialog extends Modal {
public onServiceComplete() {
this._createButton.enabled = true;
this.hideSpinner();
this.spinner = false;
}
public open() {