ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-27 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

ModeService to LanguageService var names (#20949)

Browse Source
This commit is contained in:
Charles Gagnon
2022-10-24 13:57:03 -07:00
committed by GitHub
parent de9dd34275
commit a64a33e091
11 changed files with 30 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts
View File

@@ -104,7 +104,7 @@ export class CodeComponent extends CellView implements OnInit, OnChanges {
@Inject(IWorkbenchThemeService) private themeService: IWorkbenchThemeService,
@Inject(IInstantiationService) private _instantiationService: IInstantiationService,
@Inject(IModelService) private _modelService: IModelService,
@Inject(ILanguageService) private _modeService: ILanguageService,
@Inject(ILanguageService) private _languageService: ILanguageService,
@Inject(IConfigurationService) private _configurationService: IConfigurationService,
@Inject(forwardRef(() => ChangeDetectorRef)) private _changeRef: ChangeDetectorRef,
@Inject(ILogService) private readonly logService: ILogService,
@@ -407,7 +407,7 @@ export class CodeComponent extends CellView implements OnInit, OnChanges {
private updateLanguageMode(): void {
if (this._editorModel && this._editor) {
let modeValue = this._modeService.createById(this.cellModel.language);
let modeValue = this._languageService.createById(this.cellModel.language);
this._modelService.setMode(this._editorModel, modeValue);
}
}
@@ -490,10 +490,10 @@ export class CodeComponent extends CellView implements OnInit, OnChanges {
description = localize('cellLanguageDescriptionConfigured', "({0})", lang);
}
const languageName = this._modeService.getLanguageName(lang) ?? lang;
const languageName = this._languageService.getLanguageName(lang) ?? lang;
const item = <ILanguagePickInput>{
label: languageName,
iconClasses: getIconClasses(this._modelService, this._modeService, this.getFakeResource(languageName, this._modeService)),
iconClasses: getIconClasses(this._modelService, this._languageService, this.getFakeResource(languageName, this._languageService)),
description,
languageId: lang
};
@@ -519,14 +519,14 @@ export class CodeComponent extends CellView implements OnInit, OnChanges {
/**
* Copied from coreActions.ts
*/
private getFakeResource(lang: string, modeService: ILanguageService): URI | undefined {
private getFakeResource(lang: string, languageService: ILanguageService): URI | undefined {
let fakeResource: URI | undefined;
const extensions = modeService.getExtensions(lang);
const extensions = languageService.getExtensions(lang);
if (extensions?.length) {
fakeResource = URI.file(extensions[0]);
} else {
const filenames = modeService.getFilenames(lang);
const filenames = languageService.getFilenames(lang);
if (filenames?.length) {
fakeResource = URI.file(filenames[0]);
}

2
src/sql/workbench/contrib/notebook/browser/models/notebookEditorFactory.ts
View File

@@ -24,7 +24,7 @@ const editorFactoryRegistry = Registry.as<IEditorFactoryRegistry>(EditorExtensio
export class NotebookEditorLanguageAssociation implements ILanguageAssociation {
/**
* The language IDs that are associated with Notebooks. These are case sensitive for comparing with what's
* registered in the ModeService registry.
* registered in the LanguageService registry.
*/
static readonly languages = [NotebookLanguage.Notebook, NotebookLanguage.Ipynb];

6
src/sql/workbench/contrib/notebook/browser/notebook.contribution.ts
View File

@@ -740,13 +740,13 @@ export class NotebookEditorOverrideContribution extends Disposable implements IW
@ILogService private _logService: ILogService,
@IEditorService private _editorService: IEditorService,
@IEditorResolverService private _editorResolverService: IEditorResolverService,
@ILanguageService private _modeService: ILanguageService
@ILanguageService private _languageService: ILanguageService
) {
super();
this.registerEditorOverrides();
// Refresh the editor overrides whenever the languages change so we ensure we always have
// the latest up to date list of extensions for each language
this._modeService.onDidChange(() => {
this._languageService.onDidChange(() => {
this.registerEditorOverrides();
});
notebookRegistry.onNewDescriptionRegistration(({ id, registration }) => {
@@ -765,7 +765,7 @@ export class NotebookEditorOverrideContribution extends Disposable implements IW
// List of built-in language IDs to associate the query editor for. These are case sensitive.
NotebookEditorLanguageAssociation.languages.forEach(lang => {
const langExtensions = this._modeService.getExtensions(lang);
const langExtensions = this._languageService.getExtensions(lang);
allExtensions = allExtensions.concat(langExtensions);
});

4
src/sql/workbench/contrib/notebook/test/browser/markdownTextTransformer.test.ts
View File

@@ -94,7 +94,7 @@ suite.skip('MarkdownTextTransformer', () => {
onDidChange: (_a: any) => { }
};
let modeService: any = {
let languageService: any = {
languageIdCodec: {
encodeLanguageId: (languageId: string) => { return <LanguageId>undefined; },
decodeLanguageId: (languageId: LanguageId) => { return <string>undefined; }
@@ -106,7 +106,7 @@ suite.skip('MarkdownTextTransformer', () => {
isForSimpleWidget: true, defaultEOL: DefaultEndOfLine.LF, detectIndentation: true,
indentSize: 0, insertSpaces: false, largeFileOptimizations: false, tabSize: 4, trimAutoWhitespace: false,
bracketPairColorizationOptions: { independentColorPoolPerBracketType: false, enabled: true }
}, undefined, undoRedoService, modeService,
}, undefined, undoRedoService, languageService,
languageConfigurationService);
// Couple widget with newly created text model