ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-20 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove hasEditor from ICellEditorProvider (#22145)

Browse Source
This commit is contained in:
Charles Gagnon
2023-03-06 11:02:41 -08:00
committed by GitHub
parent c882aeddb0
commit a657aa6cb5
5 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts
View File

@@ -147,10 +147,6 @@ export class CodeComponent extends CellView implements OnInit, OnChanges {
return this._editor;
}
public override hasEditor(): boolean {
return true;
}
public cellGuid(): string {
return this.cellModel.cellGuid;
}

4
src/sql/workbench/contrib/notebook/browser/cellViews/interfaces.ts
View File

@@ -38,10 +38,6 @@ export abstract class CellView extends AngularDisposable implements OnDestroy, I
return undefined;
}
public hasEditor(): boolean {
return false;
}
public abstract cellGuid(): string;
public deltaDecorations(newDecorationsRange: NotebookRange | NotebookRange[], oldDecorationsRange: NotebookRange | NotebookRange[]): void {

5
src/sql/workbench/contrib/notebook/browser/cellViews/markdownToolbar.component.ts
View File

@@ -375,10 +375,7 @@ export class MarkdownToolbarComponent extends AngularDisposable {
if (!this._cellEditor?.getEditor()?.getControl()) {
this._cellEditor = this._notebookEditor?.cellEditors?.find(e => e.cellGuid() === this.cellModel?.cellGuid);
}
if (this._cellEditor?.hasEditor) {
return this._cellEditor.getEditor()?.getControl();
}
return undefined;
return this._cellEditor.getEditor()?.getControl();
}
public async getFileContentBase64(fileUri: URI): Promise<string> {

3
src/sql/workbench/contrib/notebook/test/stubs.ts
View File

@@ -719,9 +719,6 @@ export class NotebookEditorStub implements INotebookEditor {
export class CellEditorProviderStub implements ICellEditorProvider {
isCellOutput = false;
hasEditor(): boolean {
throw new Error('Method not implemented.');
}
cellGuid(): string {
throw new Error('Method not implemented.');
}

3
src/sql/workbench/services/notebook/browser/notebookService.ts
View File

@@ -194,10 +194,9 @@ export interface INotebookSection {
}
export interface ICellEditorProvider {
hasEditor(): boolean;
isCellOutput: boolean;
cellGuid(): string;
getEditor(): BaseTextEditor<ICodeEditorViewState>;
getEditor(): BaseTextEditor<ICodeEditorViewState> | undefined;
deltaDecorations(newDecorationsRange: NotebookRange | NotebookRange[], oldDecorationsRange: NotebookRange | NotebookRange[]): void;
}