ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

profiler a11y bug fixes (#21940)

Browse Source
This commit is contained in:
Alan Ren
2023-02-14 18:48:17 -08:00
committed by GitHub
parent 447a9d0f34
commit a683b1b777
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/services/profiler/browser/profilerFilterDialog.ts
View File

@@ -28,7 +28,7 @@ import { onUnexpectedError } from 'vs/base/common/errors';
import { attachModalDialogStyler } from 'sql/workbench/common/styler'; import { attachModalDialogStyler } from 'sql/workbench/common/styler';
import { ILayoutService } from 'vs/platform/layout/browser/layoutService'; import { ILayoutService } from 'vs/platform/layout/browser/layoutService';
import { ITextResourcePropertiesService } from 'vs/editor/common/services/textResourceConfiguration'; import { ITextResourcePropertiesService } from 'vs/editor/common/services/textResourceConfiguration';
import * as aria from 'vs/base/browser/ui/aria/aria';
const ClearText: string = localize('profilerFilterDialog.clear', "Clear all"); const ClearText: string = localize('profilerFilterDialog.clear', "Clear all");
const ApplyText: string = localize('profilerFilterDialog.apply', "Apply"); const ApplyText: string = localize('profilerFilterDialog.apply', "Apply");
@@ -39,6 +39,8 @@ const RemoveText: string = localize('profilerFilterDialog.remove', "Remove this
const SaveFilterText: string = localize('profilerFilterDialog.saveFilter', "Save Filter"); const SaveFilterText: string = localize('profilerFilterDialog.saveFilter', "Save Filter");
const LoadFilterText: string = localize('profilerFilterDialog.loadFilter', "Load Filter"); const LoadFilterText: string = localize('profilerFilterDialog.loadFilter', "Load Filter");
const AddClauseText: string = localize('profilerFilterDialog.addClauseText', "Add a clause"); const AddClauseText: string = localize('profilerFilterDialog.addClauseText', "Add a clause");
const NewClauseAddedText: string = localize('profilerFilterDialog.newClauseAdded', "A new clause has been added.");
const AllClausesClearedText: string = localize('profilerFilterDialog.allClausesCleared', "All clauses have been cleared.");
const TitleIconClass: string = 'icon filterLabel'; const TitleIconClass: string = 'icon filterLabel';
const FieldText: string = localize('profilerFilterDialog.fieldColumn', "Field"); const FieldText: string = localize('profilerFilterDialog.fieldColumn', "Field");
@@ -132,6 +134,7 @@ export class ProfilerFilterDialog extends Modal {
this.addClauseRow(false); this.addClauseRow(false);
// Set keyboard focus to the newly added clause. // Set keyboard focus to the newly added clause.
this._clauseRows[this._clauseRows.length - 1]?.field?.focus(); this._clauseRows[this._clauseRows.length - 1]?.field?.focus();
aria.status(NewClauseAddedText);
}); });
this.createClauseTableActionLink(ClearText, body, () => { this.handleClearButtonClick(); }); this.createClauseTableActionLink(ClearText, body, () => { this.handleClearButtonClick(); });
} }
@@ -160,6 +163,7 @@ export class ProfilerFilterDialog extends Modal {
clause.row.remove(); clause.row.remove();
}); });
this._clauseRows = []; this._clauseRows = [];
aria.status(AllClausesClearedText);
} }
private createClauseTableActionLink(text: string, parent: HTMLElement, handler: () => void): void { private createClauseTableActionLink(text: string, parent: HTMLElement, handler: () => void): void {
@@ -238,7 +242,7 @@ export class ProfilerFilterDialog extends Modal {
const operatorDropDown = this.createSelectBox(DOM.append(row, DOM.$('td')), Operators, Operators[0], OperatorText); const operatorDropDown = this.createSelectBox(DOM.append(row, DOM.$('td')), Operators, Operators[0], OperatorText);
const valueText = new InputBox(DOM.append(row, DOM.$('td')), this.contextViewService, {}); const valueText = new InputBox(DOM.append(row, DOM.$('td')), this.contextViewService, { ariaLabel: ValueText });
this._register(attachInputBoxStyler(valueText, this._themeService)); this._register(attachInputBoxStyler(valueText, this._themeService));
const removeCell = DOM.append(row, DOM.$('td')); const removeCell = DOM.append(row, DOM.$('td'));