ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-11 18:48:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Misc UI improvements (#20723)

Browse Source 
* Add TrustServerCertificate to request body

* Preselect all dbs for migration

* Make disabled checkbox not auto selected

* Clarify assessment results in card

* Fix incorrect number of dbs ready for migration without issues to MI

* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues

* Revert "Clarify assessment results in card"

This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.

* Revert "Fix incorrect number of dbs ready for migration without issues to MI"

This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.

* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"

This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.

* Add new fields

* Fix null reference exception in SKU rec with save and close

* Remove unused files

* Warnings for in progress migrations in list view

* Fix unscrollable assessment results

* Fix updating SKU parameters before recommendations are ready

* Remove checksum info box

* Address PR feedback
This commit is contained in:
Raymond Truong
2022-10-28 10:59:53 -07:00
committed by GitHub
parent 968f4c7aa4
commit a734c9d244
12 changed files with 40 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
extensions/sql-migration/src/constants/strings.ts
View File

@@ -417,7 +417,6 @@ export const SELECT_SERVICE_PLACEHOLDER = localize('sql.migration.select.service
// database backup page
export const DATA_SOURCE_CONFIGURATION_PAGE_TITLE = localize('sql.migration.data.source.configuration.page.title', "Data source configuration");
export const DATABASE_BACKUP_PAGE_DESCRIPTION = localize('sql.migration.database.page.description', "Select the location of the database backups to use during migration.");
export const DATABASE_BACKUP_CHECKSUM_INFO_TEXT = localize('sql.migration.database.checksum.info.text', "Ensure that your backups were taken with the WITH CHECKSUM option.");
export const DATABASE_BACKUP_NC_NETWORK_SHARE_RADIO_LABEL = localize('sql.migration.nc.network.share.radio.label', "My database backups are on a network share");
export const DATABASE_BACKUP_NC_BLOB_STORAGE_RADIO_LABEL = localize('sql.migration.nc.blob.storage.radio.label', "My database backups are in an Azure Storage Blob Container");
export const DATABASE_BACKUP_NETWORK_SHARE_HEADER_TEXT = localize('sql.migration.network.share.header.text', "Network share details");
@@ -807,11 +806,8 @@ export const MIGRATION_MODE = localize('sql.migration.cutover.type', "Mode");
export const START_TIME = localize('sql.migration.start.time', "Start time");
export const FINISH_TIME = localize('sql.migration.finish.time', "Finish time");
export function STATUS_VALUE(status: string, count: number): string {
if (count > 0) {
return localize('sql.migration.status.error.count.some', "{0} (", StatusLookup[status] ?? status);
}
return localize('sql.migration.status.error.count.none', "{0}", StatusLookup[status] ?? status);
export function STATUS_VALUE(status: string): string {
return localize('sql.migration.status.value', "{0}", StatusLookup[status] ?? status);
}
export const MIGRATION_ERROR_DETAILS_TITLE = localize('sql.migration.error.details.title', "Migration error details");
@@ -869,18 +865,18 @@ export function STATUS_WARNING_COUNT(status: string, count: number): string | un
case 0:
return undefined;
case 1:
return localize('sql.migration.status.warning.count.single', "{0} Warning)", count);
return localize('sql.migration.status.warning.count.single', " ({0} warning)", count);
default:
return localize('sql.migration.status.warning.count.multiple', "{0} Warnings)", count);
return localize('sql.migration.status.warning.count.multiple', " ({0} warnings)", count);
}
} else {
switch (count) {
case 0:
return undefined;
case 1:
return localize('sql.migration.status.error.count.single', "{0} Error)", count);
return localize('sql.migration.status.error.count.single', " ({0} error)", count);
default:
return localize('sql.migration.status.error.count.multiple', "{0} Errors)", count);
return localize('sql.migration.status.error.count.multiple', " ({0} errors)", count);
}
}
}