ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Misc UI improvements (#20723)

Browse Source 
* Add TrustServerCertificate to request body

* Preselect all dbs for migration

* Make disabled checkbox not auto selected

* Clarify assessment results in card

* Fix incorrect number of dbs ready for migration without issues to MI

* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues

* Revert "Clarify assessment results in card"

This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.

* Revert "Fix incorrect number of dbs ready for migration without issues to MI"

This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.

* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"

This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.

* Add new fields

* Fix null reference exception in SKU rec with save and close

* Remove unused files

* Warnings for in progress migrations in list view

* Fix unscrollable assessment results

* Fix updating SKU parameters before recommendations are ready

* Remove checksum info box

* Address PR feedback
This commit is contained in:
Raymond Truong
2022-10-28 10:59:53 -07:00
committed by GitHub
parent 968f4c7aa4
commit a734c9d244
12 changed files with 40 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extensions/sql-migration/src/dashboard/migrationsListTab.ts
View File

@@ -9,7 +9,7 @@ import { IconPathHelper } from '../constants/iconPathHelper';
import { getCurrentMigrations, getSelectedServiceStatus } from '../models/migrationLocalStorage';
import * as loc from '../constants/strings';
import { filterMigrations, getMigrationDuration, getMigrationStatusImage, getMigrationStatusWithErrors, getMigrationTime, MenuCommands } from '../api/utils';
import { getMigrationTargetType, getMigrationMode, getMigrationModeEnum, canCancelMigration, canCutoverMigration, getMigrationStatus } from '../constants/helper';
import { getMigrationTargetType, getMigrationMode, getMigrationModeEnum, canCancelMigration, canCutoverMigration } from '../constants/helper';
import { DatabaseMigration, getResourceName } from '../api/azure';
import { logError, TelemetryViews } from '../telemtery';
import { SelectMigrationServiceDialog } from '../dialog/selectMigrationService/selectMigrationServiceDialog';
@@ -468,7 +468,7 @@ export class MigrationsListTab extends TabBase<MigrationsListTab> {
headerCssClass: headerCssStyles,
name: loc.SRC_DATABASE,
value: 'sourceDatabase',
width: 190,
width: 170,
type: azdata.ColumnType.hyperlink,
},
{
@@ -476,7 +476,7 @@ export class MigrationsListTab extends TabBase<MigrationsListTab> {
headerCssClass: headerCssStyles,
name: loc.SRC_SERVER,
value: 'sourceServer',
width: 190,
width: 170,
type: azdata.ColumnType.text,
},
<azdata.HyperlinkColumn>{
@@ -484,7 +484,7 @@ export class MigrationsListTab extends TabBase<MigrationsListTab> {
headerCssClass: headerCssStyles,
name: loc.STATUS_COLUMN,
value: 'status',
width: 120,
width: 160,
type: azdata.ColumnType.hyperlink,
},
{
@@ -559,9 +559,9 @@ export class MigrationsListTab extends TabBase<MigrationsListTab> {
const buttonState = <azdata.ICellActionEventArgs>rowState;
const migration = this._filteredMigrations[rowState.row];
switch (buttonState?.column) {
// "Migration status" column
case 2:
const status = getMigrationStatus(migration);
const statusMessage = loc.DATABASE_MIGRATION_STATUS_LABEL(status);
const statusMessage = loc.DATABASE_MIGRATION_STATUS_LABEL(getMigrationStatusWithErrors(migration));
const errors = this.getMigrationErrors(migration!);
this.showDialogMessage(
@@ -569,6 +569,7 @@ export class MigrationsListTab extends TabBase<MigrationsListTab> {
statusMessage,
errors);
break;
// "Source database" column
case 0:
await this._openMigrationDetails(migration);
break;