ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that we preserve rest of PATH when starting Jupyter (#4109)

Browse Source
This commit is contained in:
Chris LaFreniere
2019-02-21 11:54:08 -10:00
committed by GitHub
parent e345090015
commit a764a481f3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/notebook/src/jupyter/serverInstance.ts
View File

@@ -354,8 +354,8 @@ export class PerNotebookServerInstance implements IServerInstance {
let env = this.getEnvWithConfigPaths(); let env = this.getEnvWithConfigPaths();
// Setting the PATH variable here for the jupyter command. Apparently setting it above will cause the // Setting the PATH variable here for the jupyter command. Apparently setting it above will cause the
// notebook process to die even though we don't override it with the for loop logic above. // notebook process to die even though we don't override it with the for loop logic above.
delete env['Path']; let pathVariableSeparator = process.platform === 'win32' ? ';' : ':';
env['PATH'] = install.pythonEnvVarPath; env['PATH'] = install.pythonEnvVarPath + pathVariableSeparator + env['PATH'];
// 'MSHOST_TELEMETRY_ENABLED' and 'MSHOST_ENVIRONMENT' environment variables are set // 'MSHOST_TELEMETRY_ENABLED' and 'MSHOST_ENVIRONMENT' environment variables are set
// for telemetry purposes used by PROSE in the process where the Jupyter kernel runs // for telemetry purposes used by PROSE in the process where the Jupyter kernel runs