From a766e5d33496c6dac3c54de60c2bfa627ddb6cfc Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Mon, 1 Apr 2019 16:44:15 -0700 Subject: [PATCH] fix error for download extension (#4793) --- .../contrib/extensions/electron-browser/extensionsActions.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/extensions/electron-browser/extensionsActions.ts b/src/vs/workbench/contrib/extensions/electron-browser/extensionsActions.ts index a9e42fdc31..cf0dc8be78 100644 --- a/src/vs/workbench/contrib/extensions/electron-browser/extensionsActions.ts +++ b/src/vs/workbench/contrib/extensions/electron-browser/extensionsActions.ts @@ -185,7 +185,10 @@ export class InstallAction extends ExtensionAction { const extension = await this.install(this.extension); - if (extension.local) { + // {{SQL CARBON EDIT}} + // Add extension object check since ADS third party extensions will be directed to a download page + // and the extension object will be undefined. + if (extension && extension.local) { const runningExtension = await this.getRunningExtension(extension.local); if (runningExtension) { const colorThemes = await this.workbenchThemeService.getColorThemes();