ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 17:24:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

turn on noUnusedParameters in Schema Compare (#22452)

Browse Source 
* turn on noUnusedParameters in Schema Compare

* use _click

* Add names to unused parameters in test files
This commit is contained in:
Kim Santiago
2023-03-28 11:17:14 -07:00
committed by GitHub
parent 929184514e
commit a7ecff77dd
5 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/schema-compare/src/schemaCompareMainWindow.ts
View File

@@ -736,7 +736,7 @@ export class SchemaCompareMainWindow {
title: loc.compare
}).component();
this.compareButton.onDidClick(async (click) => {
this.compareButton.onDidClick(async (_click) => {
await this.startCompare();
});
}
@@ -751,7 +751,7 @@ export class SchemaCompareMainWindow {
title: loc.stop
}).component();
this.cancelCompareButton.onDidClick(async (click) => {
this.cancelCompareButton.onDidClick(async (_click) => {
await this.cancelCompare();
});
}
@@ -806,7 +806,7 @@ export class SchemaCompareMainWindow {
},
}).component();
this.generateScriptButton.onDidClick(async (click) => {
this.generateScriptButton.onDidClick(async (_click) => {
await this.generateScript();
});
}
@@ -843,7 +843,7 @@ export class SchemaCompareMainWindow {
title: loc.options
}).component();
this.optionsButton.onDidClick(async (click) => {
this.optionsButton.onDidClick(async (_click) => {
TelemetryReporter.sendActionEvent(TelemetryViews.SchemaCompareMainWindow, 'SchemaCompareOptionsOpened');
// create fresh every time
this.schemaCompareOptionDialog = new SchemaCompareOptionsDialog(this.deploymentOptions, this);
@@ -861,7 +861,7 @@ export class SchemaCompareMainWindow {
},
}).component();
this.applyButton.onDidClick(async (click) => {
this.applyButton.onDidClick(async (_click) => {
await this.publishChanges();
});
}
@@ -998,7 +998,7 @@ export class SchemaCompareMainWindow {
title: loc.switchDirectionDescription
}).component();
this.switchButton.onDidClick(async (click) => {
this.switchButton.onDidClick(async (_click) => {
TelemetryReporter.sendActionEvent(TelemetryViews.SchemaCompareMainWindow, 'SchemaCompareSwitch');
// switch source and target
[this.sourceEndpointInfo, this.targetEndpointInfo] = [this.targetEndpointInfo, this.sourceEndpointInfo];
@@ -1032,7 +1032,7 @@ export class SchemaCompareMainWindow {
secondary: true
}).component();
this.selectSourceButton.onDidClick(async () => {
this.selectSourceButton.onDidClick(async (_click) => {
TelemetryReporter.sendActionEvent(TelemetryViews.SchemaCompareMainWindow, 'SchemaCompareSelectSource');
this.schemaCompareDialog = new SchemaCompareDialog(this, undefined, this.extensionContext);
this.promise = this.schemaCompareDialog.openDialog();
@@ -1046,7 +1046,7 @@ export class SchemaCompareMainWindow {
secondary: true
}).component();
this.selectTargetButton.onDidClick(async () => {
this.selectTargetButton.onDidClick(async (_click) => {
TelemetryReporter.sendActionEvent(TelemetryViews.SchemaCompareMainWindow, 'SchemaCompareSelectTarget');
this.schemaCompareDialog = new SchemaCompareDialog(this, undefined, this.extensionContext);
this.promise = await this.schemaCompareDialog.openDialog();
@@ -1064,7 +1064,7 @@ export class SchemaCompareMainWindow {
title: loc.openScmpDescription
}).component();
this.openScmpButton.onDidClick(async (click) => {
this.openScmpButton.onDidClick(async (_click) => {
await this.openScmp();
});
}
@@ -1180,7 +1180,7 @@ export class SchemaCompareMainWindow {
enabled: false
}).component();
this.saveScmpButton.onDidClick(async (click) => {
this.saveScmpButton.onDidClick(async (_click) => {
await this.saveScmp();
});
}