From a801388e1d8504e6bddab0444d98bd8b00fbd7b4 Mon Sep 17 00:00:00 2001 From: Alexander Ivanov Date: Thu, 18 Nov 2021 15:34:52 -0800 Subject: [PATCH] Improve accessibility for wizard steps navigation (#17669) Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons. I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements: - `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link - `aria-disabled="true"` makes it say "**unavailable**; link; **" when in NVDA "browse" mode and move to the grayed-out link. So this change implements the said improvements. --- .../services/dialog/browser/wizardNavigation.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/workbench/services/dialog/browser/wizardNavigation.component.ts b/src/sql/workbench/services/dialog/browser/wizardNavigation.component.ts index 6ce6516821..fdaa6f84cc 100644 --- a/src/sql/workbench/services/dialog/browser/wizardNavigation.component.ts +++ b/src/sql/workbench/services/dialog/browser/wizardNavigation.component.ts @@ -26,7 +26,7 @@ export class WizardNavigationParams implements IBootstrapParams {
- + {{i+1}}