ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-14 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Extension unit tests should continue on error (#21099)

Browse Source 
* Extension unit tests continue on error

* Fix script syntax issue.

* Block syntax issue

* Remove condition expression

* Brings back condition for sql product build linux yml

* Comment out condition in ci.yml

* Adds continue on error clause to ci.yml extension unit tests

* Adds condition to extension unit tests step in ci.yml

* Adds run extension unit test case for fail on error

* Adds fail on error case to Run Extension Unit Tests script

* Explicitly states continue on error false.

* Format adjustment to yml file

* Changes default state to fail on error

* Update .github/workflows/ci.yml

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update build/azure-pipelines/linux/sql-product-build-linux.yml

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update build/azure-pipelines/linux/sql-product-build-linux.yml

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Brings back original comment.

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This commit is contained in:
Lewis Sanchez
2022-11-04 21:11:14 -07:00
committed by GitHub
parent facd317b4d
commit a864993e60
2 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
.github/workflows/ci.yml vendored
View File

@@ -142,9 +142,16 @@ jobs:
id: electron-unit-tests
run: DISPLAY=:10 ./scripts/test.sh --runGlob "**/sql/**/*.test.js" --coverage
- name: Run Extension Unit Tests # {{SQL CARBON EDIT}} Rename to core for clarity
id: electron-extension-unit-tests
- name: Run Extension Unit Tests (Continue on Error) # {{SQL CARBON EDIT}} Run extension unit tests (continue on error)
id: electron-extension-unit-tests-continue-on-error
run: DISPLAY=:10 ./scripts/test-extensions-unit.sh
continueOnError: true
condition: and(succeeded(), eq(variables['EXTENSION_UNIT_TESTS_FAIL_ON_ERROR'], 'false'))
- name: Run Extension Unit Tests (Fail on Error) # {{SQL CARBON EDIT}} Run extension unit tests (fail on error)
id: electron-extension-unit-tests-fail-on-error
run: DISPLAY=:10 ./scripts/test-extensions-unit.sh
condition: and(succeeded(), ne(variables['EXTENSION_UNIT_TESTS_FAIL_ON_ERROR'], 'false'))
# {{SQL CARBON EDIT}} Add coveralls. We merge first to get around issue where parallel builds weren't being combined correctly
- name: Combine code coverage files