ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-20 17:22:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL-Migration] Improve log migrations telemetry (#22927)

Browse Source 
- Bucketized errors to track top errors
- Created separate login migration specific error to improve monitoring

---------

Co-authored-by: Akshay Mata <akma@microsoft.com>
This commit is contained in:
AkshayMata
2023-05-03 10:35:44 -07:00
committed by GitHub
parent 2c07c09d0d
commit a8a88ccbeb
6 changed files with 73 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/sql-migration/src/models/loginMigrationModel.ts
View File

@@ -26,6 +26,12 @@ export enum LoginMigrationStep {
MigrationCompleted = 3,
}
export const CollectingSourceLoginsFailed = 'Collecting source logins failed';
export const CollectingTargetLoginsFailed = 'Collecting target logins failed';
export const ConnectingToTargetFailed = 'Connecting to target failed';
export const InternalServerError = 'Login Migrations Internal Server Error';
export function GetLoginMigrationStepString(step: LoginMigrationStep): string {
switch (step) {
case LoginMigrationStep.NotStarted:
@@ -159,8 +165,21 @@ export class LoginMigrationModel {
}
private setErrorCountMapPerStep(step: LoginMigrationStep, result: contracts.StartLoginMigrationResult) {
const errorCount = result.exceptionMap ? Object.keys(result.exceptionMap).length : 0;
this.errorCountMap.set(LoginMigrationStep[step], errorCount);
const errorBuckets: Map<string, number> = new Map<string, number>();
if (!result.exceptionMap) {
return;
}
for (const exceptions of Object.values(result.exceptionMap)) {
for (const exception of exceptions) {
// Get the value for the key, or the default value of t0 if he key is not in the map
const errorCount = errorBuckets.get(exception.ErrorCodeString) ?? 0;
errorBuckets.set(exception.ErrorCodeString, errorCount + 1)
}
}
this.errorCountMap.set(LoginMigrationStep[step], errorBuckets);
}
private setDurationPerStep(step: LoginMigrationStep, result: contracts.StartLoginMigrationResult) {