From a96bf181c0eaf48c83b4d78c340187c400468ee9 Mon Sep 17 00:00:00 2001
From: Charles Gagnon <chgagnon@microsoft.com>
Date: Tue, 31 Aug 2021 12:44:59 -0700
Subject: [PATCH] Remove LGTM (#16948)

---
 .lgtm/javascript-queries/promises.ql          | 33 -------------------
 .../src/services/tools/azCliTool.ts           |  2 +-
 2 files changed, 1 insertion(+), 34 deletions(-)
 delete mode 100644 .lgtm/javascript-queries/promises.ql

diff --git a/.lgtm/javascript-queries/promises.ql b/.lgtm/javascript-queries/promises.ql
deleted file mode 100644
index b1cfc9c104..0000000000
--- a/.lgtm/javascript-queries/promises.ql
+++ /dev/null
@@ -1,33 +0,0 @@
-/**
- * @name No floating promises
- * @kind problem
- * @problem.severity error
- * @id js/experimental/floating-promise
- */
-import javascript
-
-private predicate isEscapingPromise(PromiseDefinition promise) {
-  exists (DataFlow::Node escape | promise.flowsTo(escape) |
-    escape = any(DataFlow::InvokeNode invk).getAnArgument()
-    or
-    escape = any(DataFlow::FunctionNode fun).getAReturn()
-    or
-    escape = any(ThrowStmt t).getExpr().flow()
-    or
-    escape = any(GlobalVariable v).getAnAssignedExpr().flow()
-    or
-    escape = any(DataFlow::PropWrite write).getRhs()
-    or
-    exists(WithStmt with, Assignment assign |
-      with.mayAffect(assign.getLhs()) and
-      assign.getRhs().flow() = escape
-    )
-  )
-}
-
-from PromiseDefinition promise
-where
-  not exists(promise.getAMethodCall(any(string m | m = "then" or m = "catch" or m = "finally"))) and
-  not exists (AwaitExpr e | promise.flowsTo(e.getOperand().flow())) and
-  not isEscapingPromise(promise)
-select promise, "This promise appears to be a floating promise"
diff --git a/extensions/resource-deployment/src/services/tools/azCliTool.ts b/extensions/resource-deployment/src/services/tools/azCliTool.ts
index eb1498e77e..50ca8409fd 100644
--- a/extensions/resource-deployment/src/services/tools/azCliTool.ts
+++ b/extensions/resource-deployment/src/services/tools/azCliTool.ts
@@ -57,7 +57,7 @@ export class AzCliTool extends ToolBase {
 
 	protected getVersionFromOutput(output: string): SemVer | undefined {
 		if (output && output.includes('azure-cli')) {
-			return new SemVer(output.split(EOL)[0].replace('azure-cli', '').replace(/ /g, '').replace('*', '')); //lgtm [js/incomplete-sanitization]
+			return new SemVer(output.split(EOL)[0].replace('azure-cli', '').replace(/ /g, '').replace('*', ''));
 		} else {
 			return undefined;
 		}