Adding additional parameter to data workspace provider API (#13570)

This commit is contained in:
Benjin Dubishar
2020-11-30 12:52:08 -08:00
committed by GitHub
parent 426f1ae99b
commit a9eb6880d4
4 changed files with 5 additions and 4 deletions

View File

@@ -55,8 +55,9 @@ declare module 'dataworkspace' {
* *
* @param name Create a project * @param name Create a project
* @param location the parent directory of the project * @param location the parent directory of the project
* @param projectTypeId the identifier of the selected project type
*/ */
createProject(name: string, location: vscode.Uri): Promise<vscode.Uri>; createProject(name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri>;
/** /**
* Gets the supported project types * Gets the supported project types

View File

@@ -174,7 +174,7 @@ export class WorkspaceService implements IWorkspaceService {
async createProject(name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri> { async createProject(name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri> {
const provider = ProjectProviderRegistry.getProviderByProjectType(projectTypeId); const provider = ProjectProviderRegistry.getProviderByProjectType(projectTypeId);
if (provider) { if (provider) {
const projectFile = await provider.createProject(name, location); const projectFile = await provider.createProject(name, location, projectTypeId);
this.addProjectsToWorkspace([projectFile]); this.addProjectsToWorkspace([projectFile]);
this._onDidWorkspaceProjectsChange.fire(); this._onDidWorkspaceProjectsChange.fire();
return projectFile; return projectFile;

View File

@@ -29,7 +29,7 @@ export function createProjectProvider(projectTypes: IProjectType[]): IProjectPro
getProjectTreeDataProvider: (projectFile: vscode.Uri): Promise<vscode.TreeDataProvider<any>> => { getProjectTreeDataProvider: (projectFile: vscode.Uri): Promise<vscode.TreeDataProvider<any>> => {
return Promise.resolve(treeDataProvider); return Promise.resolve(treeDataProvider);
}, },
createProject: (name: string, location: vscode.Uri): Promise<vscode.Uri> => { createProject: (name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri> => {
return Promise.resolve(location); return Promise.resolve(location);
} }
}; };

View File

@@ -58,7 +58,7 @@ export class SqlDatabaseProjectProvider implements dataworkspace.IProjectProvide
* @param location the parent directory * @param location the parent directory
* @returns Uri of the newly created project file * @returns Uri of the newly created project file
*/ */
async createProject(name: string, location: vscode.Uri): Promise<vscode.Uri> { async createProject(name: string, location: vscode.Uri, _: string): Promise<vscode.Uri> {
const projectFile = await this.projectController.createNewProject(name, location, true); const projectFile = await this.projectController.createNewProject(name, location, true);
return vscode.Uri.file(projectFile); return vscode.Uri.file(projectFile);
} }