From aadc8711242e1ede19fa2a2192c44abcf1ff390b Mon Sep 17 00:00:00 2001 From: Amir Omidi Date: Fri, 20 Sep 2019 16:00:24 -0700 Subject: [PATCH] Serializer (#7309) --- .../parts/notebook/browser/outputs/gridOutput.component.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/sql/workbench/parts/notebook/browser/outputs/gridOutput.component.ts b/src/sql/workbench/parts/notebook/browser/outputs/gridOutput.component.ts index 2fda9a9e62..a59495982c 100644 --- a/src/sql/workbench/parts/notebook/browser/outputs/gridOutput.component.ts +++ b/src/sql/workbench/parts/notebook/browser/outputs/gridOutput.component.ts @@ -180,7 +180,7 @@ class DataResourceDataProvider implements IGridDataProvider { @IClipboardService private _clipboardService: IClipboardService, @IConfigurationService private _configurationService: IConfigurationService, @ITextResourcePropertiesService private _textResourcePropertiesService: ITextResourcePropertiesService, - @ISerializationService private _serializationService: ISerializationService, + @optional(ISerializationService) private _serializationService: ISerializationService, @IInstantiationService private _instantiationService: IInstantiationService ) { this.transformSource(source); @@ -248,7 +248,7 @@ class DataResourceDataProvider implements IGridDataProvider { } get canSerialize(): boolean { - return this._serializationService.hasProvider(); + return this._serializationService && this._serializationService.hasProvider(); } @@ -258,6 +258,9 @@ class DataResourceDataProvider implements IGridDataProvider { } private doSerialize(serializer: ResultSerializer, filePath: string, format: SaveFormat, selection: Slick.Range[]): Promise { + if (!this.canSerialize) { + return Promise.resolve(undefined); + } // TODO implement selection support let columns = this.resultSet.columnInfo; let rowLength = this.rows.length;