Allow data explorer to use connect (#5564)

* wip

* handle save password; get correct profile

* ensure resolve is being called

* fix tests

* fix more tests

src/sql/platform/connection/common/connectionManagement.ts

@@ -57,7 +57,7 @@ export interface IConnectionResult {
 export interface IConnectionCallbacks {
 	onConnectStart(): void;
 	onConnectReject(error?: string): void;
-	onConnectSuccess(params?: INewConnectionParams): void;
+	onConnectSuccess(params: INewConnectionParams, profile: IConnectionProfile): void;
 	onDisconnect(): void;
 	onConnectCanceled(): void;
 }
@@ -80,7 +80,7 @@ export interface IConnectionManagementService {
 	/**
 	 * Opens the connection dialog to create new connection
 	 */
-	showConnectionDialog(params?: INewConnectionParams, model?: IConnectionProfile, connectionResult?: IConnectionResult): Promise<void>;
+	showConnectionDialog(params?: INewConnectionParams, options?: IConnectionCompletionOptions, model?: IConnectionProfile, connectionResult?: IConnectionResult): Promise<void>;
 
 	/**
 	 * Opens the add server group dialog
@@ -305,7 +305,7 @@ export interface IConnectableInput {
 	uri: string;
 	onConnectStart(): void;
 	onConnectReject(error?: string): void;
-	onConnectSuccess(params?: INewConnectionParams): void;
+	onConnectSuccess(params: INewConnectionParams, profile: IConnectionProfile): void;
 	onDisconnect(): void;
 	onConnectCanceled(): void;
 }

src/sql/platform/connection/common/connectionManagementService.ts

@@ -183,7 +183,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
 	 * @param params Include the uri, type of connection
 	 * @param model the existing connection profile to create a new one from
 	 */
-	public showConnectionDialog(params?: INewConnectionParams, model?: IConnectionProfile, connectionResult?: IConnectionResult): Promise<void> {
+	public showConnectionDialog(params?: INewConnectionParams, options?: IConnectionCompletionOptions, model?: IConnectionProfile, connectionResult?: IConnectionResult): Promise<void> {
 		let self = this;
 		return new Promise<void>((resolve, reject) => {
 			if (!params) {
@@ -192,7 +192,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
 			if (!model && params.input && params.input.uri) {
 				model = this._connectionStatusManager.getConnectionProfile(params.input.uri);
 			}
-			self._connectionDialogService.showDialog(self, params, model, connectionResult).then(() => {
+			self._connectionDialogService.showDialog(self, params, model, connectionResult, options).then(() => {
 				resolve();
 			}, dialogError => {
 				this.logService.warn('failed to open the connection dialog. error: ' + dialogError);
@@ -317,7 +317,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
 					runQueryOnCompletion: RunQueryOnConnectionMode.none,
 					showDashboard: options.showDashboard
 				};
-				this.showConnectionDialog(params, connection, connectionResult).then(() => {
+				this.showConnectionDialog(params, options, connection, connectionResult).then(() => {
 					resolve(connectionResult);
 				}).catch(err => {
 					reject(err);
@@ -455,7 +455,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
 					this.tryAddActiveConnection(connectionMgmtInfo, connection, options.saveTheConnection);
 
 					if (callbacks.onConnectSuccess) {
-						callbacks.onConnectSuccess(options.params);
+						callbacks.onConnectSuccess(options.params, connectionResult.connectionProfile);
 					}
 					if (options.saveTheConnection) {
 						this.saveToSettings(uri, connection).then(value => {
@@ -466,7 +466,13 @@ export class ConnectionManagementService extends Disposable implements IConnecti
 						connection.saveProfile = false;
 						this.doActionsAfterConnectionComplete(uri, options);
 					}
-					resolve(connectionResult);
+					if (connection.savePassword) {
+						this._connectionStore.savePassword(connection).then(() => {
+							resolve(connectionResult);
+						});
+					} else {
+						resolve(connectionResult);
+					}
 				} else if (connectionResult && connectionResult.errorMessage) {
 					this.handleConnectionError(connection, uri, options, callbacks, connectionResult).then(result => {
 						resolve(result);

src/sql/platform/connection/common/connectionProfile.ts

@@ -12,6 +12,8 @@ import { generateUuid } from 'vs/base/common/uuid';
 import { ICapabilitiesService } from 'sql/platform/capabilities/common/capabilitiesService';
 import { isString } from 'vs/base/common/types';
 import { deepClone } from 'vs/base/common/objects';
+import { ConnectionOptionSpecialType } from 'sql/workbench/api/common/sqlExtHostTypes';
+import * as Constants from 'sql/platform/connection/common/constants';
 
 // Concrete implementation of the IConnectionProfile interface
 
@@ -41,6 +43,14 @@ export class ConnectionProfile extends ProviderConnectionInfo implements interfa
 			this.saveProfile = model.saveProfile;
 			this._id = model.id;
 			this.azureTenantId = model.azureTenantId;
+			if (this.capabilitiesService) {
+				const options = this.capabilitiesService.getCapabilities(model.providerName).connection.connectionOptions;
+				let appNameOption = options.find(option => option.specialValueType === ConnectionOptionSpecialType.appName);
+				if (appNameOption) {
+					let appNameKey = appNameOption.name;
+					this.options[appNameKey] = Constants.applicationName;
+				}
+			}
 		} else {
 			//Default for a new connection
 			this.savePassword = false;

src/sql/platform/connection/common/connectionStore.ts

@@ -124,6 +124,10 @@ export class ConnectionStore {
 			});
 	}
 
+	public savePassword(profile: IConnectionProfile): Promise<boolean> {
+		return this.saveProfilePasswordIfNeeded(profile);
+	}
+
 	/**
 	 * Saves a connection profile group to the user settings.
 	 *