From ab68c3060c8a58babcee63f33ff75647ece30bbb Mon Sep 17 00:00:00 2001
From: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Date: Thu, 9 Mar 2023 08:45:21 -0800
Subject: [PATCH] Add required property in missing places in sql projects
 (#22253)

* add required property for missing places in sql projects

* remove comma
---
 .../data-workspace/src/dialogs/newProjectDialog.ts   |  1 -
 .../src/dialogs/createProjectFromDatabaseDialog.ts   |  3 ++-
 .../src/dialogs/publishDatabaseDialog.ts             | 12 ++++++++----
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/extensions/data-workspace/src/dialogs/newProjectDialog.ts b/extensions/data-workspace/src/dialogs/newProjectDialog.ts
index 841f57b865..a16029a3ff 100644
--- a/extensions/data-workspace/src/dialogs/newProjectDialog.ts
+++ b/extensions/data-workspace/src/dialogs/newProjectDialog.ts
@@ -284,7 +284,6 @@ export class NewProjectDialog extends DialogBase {
 		this.formBuilder = view.modelBuilder.formContainer().withFormItems([
 			{
 				title: constants.TypeTitle,
-				required: true,
 				component: projectTypeRadioCardGroup
 			},
 			{
diff --git a/extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts b/extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
index 66dc068873..b836a38f51 100644
--- a/extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
+++ b/extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
@@ -330,7 +330,8 @@ export class CreateProjectFromDatabaseDialog {
 			value: '',
 			ariaLabel: constants.location,
 			placeHolder: constants.projectLocationPlaceholderText,
-			width: cssStyles.createProjectFromDatabaseTextboxWidth
+			width: cssStyles.createProjectFromDatabaseTextboxWidth,
+			required: true
 		}).component();
 
 		this.projectLocationTextBox.onTextChanged(() => {
diff --git a/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts b/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
index 345ec46598..ac601eb8a4 100644
--- a/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
+++ b/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
@@ -569,7 +569,8 @@ export class PublishDatabaseDialog {
 			width: cssStyles.publishDialogTextboxWidth,
 			enabled: true,
 			inputType: 'number',
-			validationErrorMessage: constants.portMustBeNumber
+			validationErrorMessage: constants.portMustBeNumber,
+			required: true
 		}).withValidation(component => utils.validateSqlServerPortNumber(component.value)).component();
 
 		this.serverPortTextBox.onTextChanged(() => {
@@ -583,7 +584,8 @@ export class PublishDatabaseDialog {
 			width: cssStyles.publishDialogTextboxWidth,
 			enabled: true,
 			inputType: 'password',
-			validationErrorMessage: constants.invalidSQLPasswordMessage(name)
+			validationErrorMessage: constants.invalidSQLPasswordMessage(name),
+			required: true
 		}).withValidation(component => !utils.isEmptyString(component.value) && utils.isValidSQLPassword(component.value || '')).component();
 
 		const serverPasswordRow = this.createFormRow(view, constants.serverPassword(name), this.serverAdminPasswordTextBox);
@@ -594,7 +596,8 @@ export class PublishDatabaseDialog {
 			width: cssStyles.publishDialogTextboxWidth,
 			enabled: true,
 			inputType: 'password',
-			validationErrorMessage: constants.passwordNotMatch(name)
+			validationErrorMessage: constants.passwordNotMatch(name),
+			required: true
 		}).withValidation(component => component.value === this.serverAdminPasswordTextBox?.value).component();
 		this.serverAdminPasswordTextBox.onTextChanged(() => {
 			this.tryEnableGenerateScriptAndOkButtons();
@@ -614,7 +617,8 @@ export class PublishDatabaseDialog {
 			values: baseImagesValues,
 			ariaLabel: constants.baseDockerImage(name),
 			width: cssStyles.publishDialogTextboxWidth,
-			enabled: true
+			enabled: true,
+			required: true
 		}).component();
 
 		const imageInfo = baseImages.find(x => x.displayName === (<azdataType.CategoryValue>this.baseDockerImageDropDown?.value)?.displayName);