diff --git a/package.json b/package.json index e8ef74cc61..41cd45d97c 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ "@angular/router": "~4.1.3", "@angular/upgrade": "~4.1.3", "angular2-grid": "2.0.6", - "angular2-slickgrid": "github:Microsoft/angular2-slickgrid#1.3.12", + "angular2-slickgrid": "github:Microsoft/angular2-slickgrid#1.4.1", "applicationinsights": "0.18.0", "chart.js": "^2.6.0", "fast-plist": "0.1.2", diff --git a/src/sql/parts/grid/views/editData/editData.component.html b/src/sql/parts/grid/views/editData/editData.component.html index b0c40be626..04f23e1980 100644 --- a/src/sql/parts/grid/views/editData/editData.component.html +++ b/src/sql/parts/grid/views/editData/editData.component.html @@ -18,12 +18,9 @@ showHeader="true" [resized]="dataSet.resized" [plugins]="plugins[i]" - (activeCellChanged)="onActiveCellChanged($event)" - (cellEditBegin)="onCellEditBegin($event)" - (cellEditExit)="onCellEditEnd($event)" - (rowEditBegin)="onRowEditBegin($event)" - (rowEditExit)="onRowEditEnd($event)" - (contextMenu)="openContextMenu($event, dataSet.batchId, dataSet.resultId, i)" + (onActiveCellChanged)="onActiveCellChanged($event)" + (onCellChange)="onCellEditEnd($event)" + (onContextMenu)="openContextMenu($event, dataSet.batchId, dataSet.resultId, i)" [isCellEditValid]="onIsCellEditValid" [overrideCellFn]="overrideCellFn" enableEditing="true" diff --git a/src/sql/parts/grid/views/editData/editData.component.ts b/src/sql/parts/grid/views/editData/editData.component.ts index a04b7ab652..38e8e729f0 100644 --- a/src/sql/parts/grid/views/editData/editData.component.ts +++ b/src/sql/parts/grid/views/editData/editData.component.ts @@ -71,11 +71,8 @@ export class EditDataComponent extends GridParentComponent implements OnInit, On protected plugins = new Array>>(); // Edit Data functions - public onActiveCellChanged: (event: { row: number, column: number }) => void; - public onCellEditEnd: (event: { row: number, column: number, newValue: any }) => void; - public onCellEditBegin: (event: { row: number, column: number }) => void; - public onRowEditBegin: (event: { row: number }) => void; - public onRowEditEnd: (event: { row: number }) => void; + public onActiveCellChanged: (event: Slick.OnActiveCellChangedEventArgs) => void; + public onCellEditEnd: (event: Slick.OnCellChangeEventArgs) => void; public onIsCellEditValid: (row: number, column: number, newValue: any) => boolean; public onIsColumnEditable: (column: number) => boolean; public overrideCellFn: (rowNumber, columnId, value?, data?) => string; @@ -167,17 +164,11 @@ export class EditDataComponent extends GridParentComponent implements OnInit, On this.onActiveCellChanged = this.onCellSelect; - this.onCellEditEnd = (event: { row: number, column: number, newValue: any }): void => { + this.onCellEditEnd = (event: Slick.OnCellChangeEventArgs): void => { // Store the value that was set - self.currentEditCellValue = event.newValue; + self.currentEditCellValue = event.item[event.cell - 1]; }; - this.onCellEditBegin = (event: { row: number, column: number }): void => { }; - - this.onRowEditBegin = (event: { row: number }): void => { }; - - this.onRowEditEnd = (event: { row: number }): void => { }; - this.overrideCellFn = (rowNumber, columnId, value?, data?): string => { let returnVal = ''; if (Services.DBCellValue.isDBCellValue(value)) { @@ -233,10 +224,10 @@ export class EditDataComponent extends GridParentComponent implements OnInit, On }; } - onCellSelect(event: { row: number, column: number }): void { + onCellSelect(event: Slick.OnActiveCellChangedEventArgs): void { let self = this; let row = event.row; - let column = event.column; + let column = event.cell; // Skip processing if the newly selected cell is undefined or we don't have column // definition for the column (ie, the selection was reset) diff --git a/src/sql/parts/grid/views/gridParentComponent.ts b/src/sql/parts/grid/views/gridParentComponent.ts index c171732d8d..5fe5ee4a5c 100644 --- a/src/sql/parts/grid/views/gridParentComponent.ts +++ b/src/sql/parts/grid/views/gridParentComponent.ts @@ -80,16 +80,6 @@ export abstract class GridParentComponent { @ViewChildren('slickgrid') slickgrids: QueryList; - // Edit Data functions - public onActiveCellChanged: (event: { row: number, column: number }) => void; - public onCellEditEnd: (event: { row: number, column: number, newValue: any }) => void; - public onCellEditBegin: (event: { row: number, column: number }) => void; - public onRowEditBegin: (event: { row: number }) => void; - public onRowEditEnd: (event: { row: number }) => void; - public onIsCellEditValid: (row: number, column: number, newValue: any) => boolean; - public overrideCellFn: (rowNumber, columnId, value?, data?) => string; - public loadDataFunction: (offset: number, count: number) => Promise; - set messageActive(input: boolean) { this._messageActive = input; if (this.resultActive) { diff --git a/yarn.lock b/yarn.lock index a74d8c2693..b0c09857cf 100644 --- a/yarn.lock +++ b/yarn.lock @@ -174,9 +174,9 @@ angular2-grid@2.0.6: version "2.0.6" resolved "https://registry.yarnpkg.com/angular2-grid/-/angular2-grid-2.0.6.tgz#01fe225dc13b2822370b6c61f9a6913b3a26f989" -"angular2-slickgrid@github:Microsoft/angular2-slickgrid#1.3.12": - version "1.3.12" - resolved "https://codeload.github.com/Microsoft/angular2-slickgrid/tar.gz/19aafe8888d2f2eb70aec858e4b86e3c1b7b3fc8" +"angular2-slickgrid@github:Microsoft/angular2-slickgrid#1.4.1": + version "1.4.1" + resolved "https://codeload.github.com/Microsoft/angular2-slickgrid/tar.gz/e13c098aa50f43de21a5fdcd1a1a0263455b92d6" ansi-colors@^1.0.1: version "1.1.0"