diff --git a/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts b/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts index 4a652705fd..d19fefab79 100644 --- a/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts +++ b/extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts @@ -80,7 +80,6 @@ export class PublishDatabaseDialog { private initializePublishTab(): void { this.publishTab.registerContent(async view => { - // TODO : enable using this when data source creation is enabled this.createRadioButtons(view); @@ -408,7 +407,7 @@ export class PublishDatabaseDialog { const table = view.modelBuilder.declarativeTable().withProperties({ ariaLabel: constants.sqlCmdTableLabel, - data: this.convertSqlCmdVarsToTableFormat(this.sqlCmdVars), + dataValues: this.convertSqlCmdVarsToTableFormat(this.sqlCmdVars), columns: [ { displayName: constants.sqlCmdVariableColumn, @@ -431,8 +430,8 @@ export class PublishDatabaseDialog { table.onDataChanged(() => { this.sqlCmdVars = {}; - table.data?.forEach((row) => { - (>this.sqlCmdVars)[row[0]] = row[1]; + table.dataValues?.forEach((row) => { + (>this.sqlCmdVars)[row[0].value] = row[1].value; }); this.tryEnableGenerateScriptAndOkButtons(); @@ -455,9 +454,10 @@ export class PublishDatabaseDialog { loadSqlCmdVarsButton.onDidClick(async () => { this.sqlCmdVars = { ...this.project.sqlCmdVariables }; - const data = this.convertSqlCmdVarsToTableFormat(this.getSqlCmdVariablesForPublish()); - await (this.sqlCmdVariablesTable).updateProperties({ - data: data + const data = this.convertSqlCmdVarsToTableFormat(this.sqlCmdVars!); + (this.sqlCmdVariablesTable)!.updateProperties({ + dataValues: data, + data: [] // data is deprecated, but the table gets updated incorrectly if this isn't set to an empty array }); this.tryEnableGenerateScriptAndOkButtons(); @@ -586,10 +586,10 @@ export class PublishDatabaseDialog { return loadProfileButton; } - private convertSqlCmdVarsToTableFormat(sqlCmdVars: Record): string[][] { + private convertSqlCmdVarsToTableFormat(sqlCmdVars: Record): azdata.DeclarativeTableCellValue[][] { let data = []; for (let key in sqlCmdVars) { - data.push([key, sqlCmdVars[key]]); + data.push([{ value: key }, { value: sqlCmdVars[key] }]); } return data;