ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Fix double-click to edit with source as array (#7027)

Browse Source 
* Fix dbl click to  edit with source as array

* Fix equality check
This commit is contained in:
Chris LaFreniere
2019-09-03 10:37:19 -07:00
committed by Karl Burtram
parent a5c824a318
commit acc85c2c23
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/workbench/parts/notebook/electron-browser/cellViews/textCell.component.ts
View File

@@ -164,10 +164,12 @@ export class TextCellComponent extends CellView implements OnInit, OnChanges {
*/ */
private updatePreview(): void { private updatePreview(): void {
let trustedChanged = this.cellModel && this._lastTrustedMode !== this.cellModel.trustedMode; let trustedChanged = this.cellModel && this._lastTrustedMode !== this.cellModel.trustedMode;
let contentChanged = this._content !== this.cellModel.source || this.cellModel.source.length === 0; let cellModelSourceJoined = Array.isArray(this.cellModel.source) ? this.cellModel.source.join('') : this.cellModel.source;
let contentJoined = Array.isArray(this._content) ? this._content.join('') : this._content;
let contentChanged = contentJoined !== cellModelSourceJoined || cellModelSourceJoined.length === 0;
if (trustedChanged || contentChanged) { if (trustedChanged || contentChanged) {
this._lastTrustedMode = this.cellModel.trustedMode; this._lastTrustedMode = this.cellModel.trustedMode;
if (!this.cellModel.source && !this.isEditMode) { if ((!cellModelSourceJoined) && !this.isEditMode) {
this._content = localize('doubleClickEdit', "Double-click to edit"); this._content = localize('doubleClickEdit', "Double-click to edit");
} else { } else {
this._content = this.cellModel.source; this._content = this.cellModel.source;