ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Even more strictness (#11879)

Browse Source 
* add more to strict nulls

* maintain error handling properly

* fix lint

* the rest of workbench/services

* fix compile
This commit is contained in:
Anthony Dresser
2020-08-20 14:00:26 -07:00
committed by GitHub
parent ca2b893c2c
commit adfdd56907
23 changed files with 260 additions and 302 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/services/bootstrap/browser/bootstrapService.ts
View File

@@ -29,7 +29,7 @@ export function providerIterator(service: IInstantiationService): Provider[] {
function createUniqueSelector(selector: string): string {
let num: number;
if (selectorCounter.has(selector)) {
num = selectorCounter.get(selector);
num = selectorCounter.get(selector)!;
} else {
num = 0;
}

45
src/sql/workbench/services/bootstrap/browser/commonServiceInterface.service.ts
View File

@@ -95,13 +95,13 @@ export class SingleQueryManagementService {
*/
@Injectable()
export class CommonServiceInterface extends AngularDisposable {
protected _uri: string;
protected _uri!: string;
/* Special Services */
protected _singleMetadataService: SingleConnectionMetadataService;
protected _singleConnectionManagementService: SingleConnectionManagementService;
protected _singleAdminService: SingleAdminService;
protected _singleQueryManagementService: SingleQueryManagementService;
protected _singleMetadataService?: SingleConnectionMetadataService;
protected _singleConnectionManagementService?: SingleConnectionManagementService;
protected _singleAdminService?: SingleAdminService;
protected _singleQueryManagementService?: SingleQueryManagementService;
public scopedContextKeyService: IContextKeyService;
protected _connectionContextKey: ConnectionContextKey;
@@ -114,36 +114,25 @@ export class CommonServiceInterface extends AngularDisposable {
@Inject(IQueryManagementService) protected _queryManagementService: IQueryManagementService
) {
super();
// during testing there may not be params
if (this._params) {
this.scopedContextKeyService = this._params.scopedContextService;
this._connectionContextKey = this._params.connectionContextKey;
this.uri = this._params.ownerUri;
}
this.scopedContextKeyService = this._params.scopedContextService;
this._connectionContextKey = this._params.connectionContextKey;
this.uri = this._params.ownerUri;
}
public get metadataService(): SingleConnectionMetadataService {
return this._singleMetadataService;
return this._singleMetadataService!;
}
public get connectionManagementService(): SingleConnectionManagementService {
return this._singleConnectionManagementService;
return this._singleConnectionManagementService!;
}
public get adminService(): SingleAdminService {
return this._singleAdminService;
return this._singleAdminService!;
}
public get queryManagementService(): SingleQueryManagementService {
return this._singleQueryManagementService;
}
protected setUri(uri: string) {
this._uri = uri;
this._singleMetadataService = new SingleConnectionMetadataService(this._metadataService, this._uri);
this._singleConnectionManagementService = new SingleConnectionManagementService(this._connectionManagementService, this._uri, this._connectionContextKey);
this._singleAdminService = new SingleAdminService(this._adminService, this._uri);
this._singleQueryManagementService = new SingleQueryManagementService(this._queryManagementService, this._uri);
return this._singleQueryManagementService!;
}
/**
@@ -151,11 +140,15 @@ export class CommonServiceInterface extends AngularDisposable {
* Inits all the services that depend on knowing a uri
*/
protected set uri(uri: string) {
this.setUri(uri);
this._uri = uri;
this._singleMetadataService = new SingleConnectionMetadataService(this._metadataService, this._uri);
this._singleConnectionManagementService = new SingleConnectionManagementService(this._connectionManagementService, this._uri, this._connectionContextKey);
this._singleAdminService = new SingleAdminService(this._adminService, this._uri);
this._singleQueryManagementService = new SingleQueryManagementService(this._queryManagementService, this._uri);
}
protected get uri(): string {
return this._uri;
return this._uri!;
}
/**
@@ -163,7 +156,7 @@ export class CommonServiceInterface extends AngularDisposable {
* In general don't use this, use specific services instances exposed publicly
*/
public getUnderlyingUri(): string {
return this._uri;
return this._uri!;
}
public getOriginalConnectionProfile(): IConnectionProfile {