From b00352570b2c16a030f7472b2b9796e1943a2e91 Mon Sep 17 00:00:00 2001
From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Date: Thu, 21 Mar 2019 16:06:17 -0700
Subject: [PATCH] Fix the "Failed to show notebook document" errors (#4649)

---
 .../workbench/api/node/extHostNotebookDocumentsAndEditors.ts    | 2 +-
 src/sql/workbench/api/node/sqlExtHost.protocol.ts               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/sql/workbench/api/node/extHostNotebookDocumentsAndEditors.ts b/src/sql/workbench/api/node/extHostNotebookDocumentsAndEditors.ts
index 9044ba9e20..3214f4dbc5 100644
--- a/src/sql/workbench/api/node/extHostNotebookDocumentsAndEditors.ts
+++ b/src/sql/workbench/api/node/extHostNotebookDocumentsAndEditors.ts
@@ -109,7 +109,7 @@ export class ExtHostNotebookDocumentsAndEditors implements ExtHostNotebookDocume
 					this._mainContext.getProxy(SqlMainContext.MainThreadNotebookDocumentsAndEditors),
 					data.id,
 					documentData,
-					typeConverters.ViewColumn.to(data.editorPosition)
+					typeof data.editorPosition === 'number' ? typeConverters.ViewColumn.to(data.editorPosition) : undefined
 				);
 				this._editors.set(data.id, editor);
 			}
diff --git a/src/sql/workbench/api/node/sqlExtHost.protocol.ts b/src/sql/workbench/api/node/sqlExtHost.protocol.ts
index 7be6fa66d2..2595092b42 100644
--- a/src/sql/workbench/api/node/sqlExtHost.protocol.ts
+++ b/src/sql/workbench/api/node/sqlExtHost.protocol.ts
@@ -840,7 +840,7 @@ export interface INotebookModelChangedData {
 export interface INotebookEditorAddData {
 	id: string;
 	documentUri: UriComponents;
-	editorPosition: EditorViewColumn;
+	editorPosition: EditorViewColumn | undefined;
 }
 
 export interface INotebookShowOptions {